Closed
Bug 1371536
Opened 7 years ago
Closed 7 years ago
Suppress more MSVC warnings in media/libspeex_resampler
Categories
(Core :: Audio/Video: Playback, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: emk, Assigned: emk)
Details
Attachments
(1 file)
3:30.15 warning: media/libspeex_resampler/src/resample.c:687 [C4018] '<': signed と unsigned の数値を比較しようとしました。 3:30.15 warning: media/libspeex_resampler/src/resample.c:814 [C4101] 'i': ローカル変数は 1 度も使われていません。 3:30.15 warning: media/libspeex_resampler/src/resample.c:960 [C4018] '<': signed と unsigned の数値を比較しようとしました。 3:30.15 warning: media/libspeex_resampler/src/resample.c:963 [C4018] '<': signed と unsigned の数値を比較しようとしました。 3:30.15 warning: media/libspeex_resampler/src/resample.c:1016 [C4018] '<': signed と unsigned の数値を比較しようとしました。 3:30.16 warning: media/libspeex_resampler/src/resample.c:1023 [C4018] '<': signed と unsigned の数値を比較しようとしました。 3:30.16 warning: media/libspeex_resampler/src/resample.c:1033 [C4018] '<': signed と unsigned の数値を比較しようとしました。 3:30.16 warning: media/libspeex_resampler/src/resample_sse.c:47 [C4018] '<': signed と unsigned の数値を比較しようとしました。 3:30.16 warning: media/libspeex_resampler/src/resample_sse.c:64 [C4018] '<': signed と unsigned の数値を比較しようとしました。 3:30.16 warning: media/libspeex_resampler/src/resample_sse.c:86 [C4018] '<': signed と unsigned の数値を比較しようとしました。 3:30.16 warning: media/libspeex_resampler/src/resample_sse.c:112 [C4018] '<': signed と unsigned の数値を比較しようとしました。
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8876012 [details] Bug 1371536 - Suppress more MSVC warnings in media/libspeex_resampler. https://reviewboard.mozilla.org/r/147454/#review152282 Thanks!
Attachment #8876012 -
Flags: review?(padenot) → review+
Pushed by VYV03354@nifty.ne.jp: https://hg.mozilla.org/integration/autoland/rev/c7979b14d998 Suppress more MSVC warnings in media/libspeex_resampler. r=padenot
Updated•7 years ago
|
Component: Audio/Video → Audio/Video: Playback
Comment 4•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c7979b14d998
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Comment 5•7 years ago
|
||
This reduced lots of compiler errors for the Windows platform. Thanks! == Change summary for alert #7210 (as of June 12 2017 13:23 UTC) == Improvements: 8% compiler warnings summary windowsxp opt 145.00 -> 134.00 8% compiler warnings summary windows2012-32 opt 145.00 -> 134.00 7% compiler warnings summary windows2012-32-noopt debug 151.00 -> 140.00 7% compiler warnings summary windowsxp debug 151.00 -> 140.00 7% compiler warnings summary windows2012-32 debug 151.00 -> 140.00 7% compiler warnings summary windows2012-32 pgo 156.50 -> 145.42 7% compiler warnings summary windows8-64 opt 164.00 -> 153.00 7% compiler warnings summary windows2012-64 opt 164.00 -> 153.00 6% compiler warnings summary windows2012-64-noopt debug 171.00 -> 160.00 6% compiler warnings summary windows8-64 debug 171.00 -> 160.00 6% compiler warnings summary windows2012-64 debug 171.00 -> 160.00 6% compiler warnings summary windows2012-64 pgo 175.25 -> 164.33 For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=7210
You need to log in
before you can comment on or make changes to this bug.
Description
•