1371545 - Remove NS_ERROR_IMAGE_SRC_CHANGED and NS_ERROR_IMAGE_BLOCKED

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

In Bug 1267075 I removed the caller that using NS_ERROR_IMAGE_BLOCKED, and we found out that although we post SRC_CHANGED to mCurrentRequest/mPendingRequest in 
http://searchfox.org/mozilla-central/rev/a798ee4fc323f9387b7576dbed177859d29d09b7/dom/base/nsImageLoadingContent.cpp#1256

In the end, the status code is ignored and post NS_BINDING_ABORTED.
http://searchfox.org/mozilla-central/rev/1a054419976437d0778a2b89be1b00207a744e94/image/imgRequest.cpp#284

So Bz suggested that we could remove these two error code in 
https://bugzilla.mozilla.org/show_bug.cgi?id=1267075#c75

However I found I also need to update servo as well, so file this as a seperate bug.

Comment 1

[Boris Zbarsky [:bzbarsky]]

For what it's worth, you can just land the Gecko removal (and this bug is fine for that).  The servo part doesn't depend on these being present in Gecko in any way, so can be done as an independent PR after the Gecko landing or will happen automatically when someone next reruns bindgen.

Comment 2

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch.

Hi Timothy
I originally plan to flag r? to bz, but he's on PTO.
Since this is an error code for image status, could you review this for me?

Thanks

Comment 3

[Timothy Nikkel (:tnikkel)]

Comment on attachment 8899723 [details] [diff] [review]
Patch.

This seems reasonable to me but I don't know anything about this file or what depends on it, so I'd rather someone else review. Sorry.

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 8899723 [details] [diff] [review]
Patch.

Review of attachment 8899723 [details] [diff] [review]:
-----------------------------------------------------------------

Hi smaug
The status code was there since Mozilla is released, since bz and tnikkel cannot review now, could you help to review this?

Thanks

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8899723 [details] [diff] [review]
Patch.

Please remove the comment in http://searchfox.org/mozilla-central/rev/48ea452803907f2575d81021e8678634e8067fc2/dom/base/nsImageLoadingContent.cpp#1376

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9667dcce1a84
Remove NS_ERROR_IMAGE_SRC_CHANGED and NS_ERROR_IMAGE_BLOCKED. r=smaug

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9667dcce1a84