Closed Bug 1371555 Opened 7 years ago Closed 7 years ago

SetWindowRect has to return WindowRect and not ElementRect

Categories

(Testing :: geckodriver, defect)

Product:
Testing
Component:
geckodriver
Version:
55 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox55 affected)

Status:
RESOLVED DUPLICATE of bug 1371405
Tracking Flags:
Tracking Status
firefox55 --- affected

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

Caused by bug 1366728, which should be easy to fix. Lets squeeze this tiny change into the 0.17.0 release too, to make it great.
Oh, and we also interpret x, y, width, and height as float and not u64!
Why does the ElementRectResponse allow floats? Shouldn't it be i64, and u64 too like for WindowRectResponse?

https://github.com/mozilla/webdriver-rust/blob/master/src/response.rs#L122
Flags: needinfo?(james)
Flags: needinfo?(dburns)
The change was done in:
https://github.com/mozilla/webdriver-rust/commit/f488c3ed90f41406b3062e200bded4398effe442

Sadly no information has been provided why this change was done. :/ When can screen coordinates be floats?
Because the spec says that DOMRect, the return type of getBoundingClientRect, stores its properties as floats: https://drafts.fxtf.org/geometry/#DOMRect
Flags: needinfo?(james)
I see. Thanks. 

Also it looks like that David took care of everything via bug 1371405.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
Flags: needinfo?(dburns)
No longer blocks: 1369709
You need to log in before you can comment on or make changes to this bug.