1371557 - Enable depth buffer on GLContextProviderEGL

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Sotaro Ikeda [:sotaro]]

Depth buffer was enabled by Bug 1329574 except GLContextProviderEGL. And on windows, I some time saw a wired rendering. It seems to caused by no depth buffer.

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Enable depth buffer on GLContextProviderEGL

Comment 2

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Enable depth buffer on GLContextProviderEGL

Comment 3

[Sotaro Ikeda [:sotaro]]

Comment on attachment 8876043 [details] [diff] [review]
patch - Enable depth buffer on GLContextProviderEGL

I am going to update a patch.

Comment 4

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Enable depth buffer on GLContextProviderEGL

Comment 5

[Sotaro Ikeda [:sotaro]]

I saw the problem when scrolling the following page on windows without attachment 8876048 [details] [diff] [review]. Video seemed not clipped correctly.
  https://www.youtube.com/watch?v=jhOVibLEDhA

Comment 6

[Nicolas Silva [:nical]]

Comment on attachment 8876048 [details] [diff] [review]
patch - Enable depth buffer on GLContextProviderEGL

Review of attachment 8876048 [details] [diff] [review]:
-----------------------------------------------------------------

Instead of adding the notion of webrender inside of GLContext, please rename this parameter into something more akin to the level of abstraction that GLContext sits at, for example "aEnableDepthBuffer".

Comment 7

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Enable depth buffer on GLContextProviderEGL for webrender

Comment 8

[Sotaro Ikeda [:sotaro]]

attachment 8877383 [details] [diff] [review] applied the comment.

Comment 9

[Nicolas Silva [:nical]]

Comment on attachment 8877383 [details] [diff] [review]
patch - Enable depth buffer on GLContextProviderEGL for webrender

Review of attachment 8877383 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 10

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e2c2c68f7c31f80d6a7b5f435d88bfc15d45f07a

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c16210763445
Enable depth buffer on GLContextProviderEGL for webrender r=nical

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/c16210763445