Closed Bug 1371557 Opened 2 years ago Closed 2 years ago

Enable depth buffer on GLContextProviderEGL

Categories

(Core :: Graphics: WebRender, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: sotaro, Assigned: sotaro)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 3 obsolete files)

Depth buffer was enabled by Bug 1329574 except GLContextProviderEGL. And on windows, I some time saw a wired rendering. It seems to caused by no depth buffer.
Assignee: nobody → sotaro.ikeda.g
Blocks: webrender
Attachment #8876041 - Attachment is obsolete: true
Attachment #8876043 - Flags: review?(nical.bugzilla)
Comment on attachment 8876043 [details] [diff] [review]
patch - Enable depth buffer on GLContextProviderEGL

I am going to update a patch.
Attachment #8876043 - Flags: review?(nical.bugzilla)
Attachment #8876043 - Attachment is obsolete: true
Attachment #8876048 - Flags: review?(nical.bugzilla)
Blocks: 1372083
I saw the problem when scrolling the following page on windows without attachment 8876048 [details] [diff] [review]. Video seemed not clipped correctly.
  https://www.youtube.com/watch?v=jhOVibLEDhA
Comment on attachment 8876048 [details] [diff] [review]
patch - Enable depth buffer on GLContextProviderEGL

Review of attachment 8876048 [details] [diff] [review]:
-----------------------------------------------------------------

Instead of adding the notion of webrender inside of GLContext, please rename this parameter into something more akin to the level of abstraction that GLContext sits at, for example "aEnableDepthBuffer".
Attachment #8876048 - Attachment is obsolete: true
Attachment #8876048 - Flags: review?(nical.bugzilla)
attachment 8877383 [details] [diff] [review] applied the comment.
Attachment #8877383 - Flags: review?(nical.bugzilla)
Comment on attachment 8877383 [details] [diff] [review]
patch - Enable depth buffer on GLContextProviderEGL for webrender

Review of attachment 8877383 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8877383 - Flags: review?(nical.bugzilla) → review+
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c16210763445
Enable depth buffer on GLContextProviderEGL for webrender r=nical
https://hg.mozilla.org/mozilla-central/rev/c16210763445
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.