Enable depth buffer on GLContextProviderEGL

RESOLVED FIXED in Firefox 56

Status

()

RESOLVED FIXED
a year ago
a year ago

People

(Reporter: sotaro, Assigned: sotaro)

Tracking

(Blocks: 1 bug)

unspecified
mozilla56
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(1 attachment, 3 obsolete attachments)

(Assignee)

Description

a year ago
Depth buffer was enabled by Bug 1329574 except GLContextProviderEGL. And on windows, I some time saw a wired rendering. It seems to caused by no depth buffer.
(Assignee)

Updated

a year ago
Assignee: nobody → sotaro.ikeda.g
(Assignee)

Updated

a year ago
Blocks: 1311790
(Assignee)

Comment 1

a year ago
Created attachment 8876041 [details] [diff] [review]
patch - Enable depth buffer on GLContextProviderEGL
(Assignee)

Comment 2

a year ago
Created attachment 8876043 [details] [diff] [review]
patch - Enable depth buffer on GLContextProviderEGL
Attachment #8876041 - Attachment is obsolete: true
(Assignee)

Updated

a year ago
Attachment #8876043 - Flags: review?(nical.bugzilla)
(Assignee)

Comment 3

a year ago
Comment on attachment 8876043 [details] [diff] [review]
patch - Enable depth buffer on GLContextProviderEGL

I am going to update a patch.
Attachment #8876043 - Flags: review?(nical.bugzilla)
(Assignee)

Comment 4

a year ago
Created attachment 8876048 [details] [diff] [review]
patch - Enable depth buffer on GLContextProviderEGL
Attachment #8876043 - Attachment is obsolete: true
(Assignee)

Updated

a year ago
Attachment #8876048 - Flags: review?(nical.bugzilla)
(Assignee)

Updated

a year ago
Blocks: 1372083
(Assignee)

Comment 5

a year ago
I saw the problem when scrolling the following page on windows without attachment 8876048 [details] [diff] [review]. Video seemed not clipped correctly.
  https://www.youtube.com/watch?v=jhOVibLEDhA
Comment on attachment 8876048 [details] [diff] [review]
patch - Enable depth buffer on GLContextProviderEGL

Review of attachment 8876048 [details] [diff] [review]:
-----------------------------------------------------------------

Instead of adding the notion of webrender inside of GLContext, please rename this parameter into something more akin to the level of abstraction that GLContext sits at, for example "aEnableDepthBuffer".
(Assignee)

Comment 7

a year ago
Created attachment 8877383 [details] [diff] [review]
patch - Enable depth buffer on GLContextProviderEGL for webrender
Attachment #8876048 - Attachment is obsolete: true
Attachment #8876048 - Flags: review?(nical.bugzilla)
(Assignee)

Comment 8

a year ago
attachment 8877383 [details] [diff] [review] applied the comment.
(Assignee)

Updated

a year ago
Attachment #8877383 - Flags: review?(nical.bugzilla)
Comment on attachment 8877383 [details] [diff] [review]
patch - Enable depth buffer on GLContextProviderEGL for webrender

Review of attachment 8877383 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8877383 - Flags: review?(nical.bugzilla) → review+

Comment 11

a year ago
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c16210763445
Enable depth buffer on GLContextProviderEGL for webrender r=nical
https://hg.mozilla.org/mozilla-central/rev/c16210763445
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.