1371566 - Can't delete a note (neither from the notes table nor from a release form)

Status: RESOLVED FIXED

(Websites :: Nucleus, enhancement)

Description

[Pascal Chevrel:pascalc]

We (myself and gchang) can't remove notes in Nucleus.

If I go to https://nucleus.mozilla.org/admin/rna/note/ and select the note we want to delete (ID: 787122) and choose the "Delete selected notes" in the UI, I get a "403 Forbidden" message.

If I go to a specific release (https://nucleus.mozilla.org/admin/rna/release/549/) and click on the "remove" button for that note, I get javascript popup with the message "Unable to complete request: 0 error"

I don't know if this is a question of unsufficient rights for our accounts or if it is a problem with the application itself.

Comment 1

[Paul [:pmac] McLanahan]

The inability to delete notes in the admin is by design. Deletion causes sync errors with the bedrock clients, and so it's been disabled. The way to work around this is to either edit or remove the note.

So it sounds like the issue is the error when trying to remove a note from a release. I'm looking into that now. That should definitely work and is the right way to go about discarding a note.

Comment 2

[Paul [:pmac] McLanahan]

Talked with Pascal about this on IRC. They (he) did work around this with the following method:

1. Go to the page in the admin for the specific note inquestion (e.g. https://nucleus.mozilla.org/admin/rna/note/787122/)
2. Move any releases from which you want to remove the note from the "Chosen releases" box to the "Available releases" box via the controls
3. Save the changes

This is the same basic procedure done by the more convenient "Remove" button on the Release admin page that is not working at the moment. Until I can get the button fixed please use the above procedure should you need to remove a note from a release.

I just wanted to get that down here in case someone else needs this and happens upon this bug. I'll add more when I figure out the button issue.

Comment 3

[Jorg K (CEST = GMT+2)]

(In reply to Paul [:pmac] McLanahan from comment #2)
> This is the same basic procedure done by the more convenient "Remove" button
> on the Release admin page that is not working at the moment.
Not only that:
Clicking "Make release-specific" gives an error and then goes ahead and duplicates the note.
That worked before.

Comment 4

[Paul [:pmac] McLanahan]

Okay thanks. Something has obviously changed about how the JS is handled in the admin. I'll see what I can figure out.

Comment 5

[Jorg K (CEST = GMT+2)]

Due to the two issues mentioned here I created a heap of orphaned notes. It would be good to be able to permanently delete/purge/destroy/obliterate orphaned notes.

Comment 6

[Jorg K (CEST = GMT+2)]

Any update on this? Having to edit 12 notes in a duplicated release just because the "Remove" button doesn't work is a real pain.

Comment 7

[Paul [:pmac] McLanahan]

Yes. Apologies for the delay. I believe this is happening because of a misconfiguration in our new server cluster. The app isn't being told its being served over HTTPS and is therefore allowing some URLs to stay as "http". The error is that the URL the admin is attempting to load for the notes is http and the browser's mixed-content protection is blocking it. I've just submitted a PR that should fix this[0]. I'll update this bug when these changes are in prod so you can test.

[0] https://github.com/mozilla/nucleus/pull/26

Comment 8

[[github robot]]

Commits pushed to master at https://github.com/mozilla/nucleus

https://github.com/mozilla/nucleus/commit/5c711c8c1a2baceceb5963fb8be871e7adc938e6
Fix bug 1371566: Support HTTPS environment variable for SSL settings

Copy the way Bedrock does this. Required for HTTPS support
in Deis Workflow clusters.

https://github.com/mozilla/nucleus/commit/24e0afc52f52846e99f60d264e1136bd77575199
Merge pull request #26 from pmac/fix-admin-note-buttons-1371566

Fix bug 1371566: Support HTTPS environment variable for SSL settings

Comment 9

[Paul [:pmac] McLanahan]

It's deployed and things seem to be working normally again. Give it a try and mark this as verified if it has resolved the issue.