1371575 - Handle missing images in theme.update consistently

Status: NEW

(WebExtensions :: Themes, defect, P5)

Description

[CosminB]

[Affected versions]:
- Firefox 55.0a1 (20170608030205)
 
[Affected platforms]:
- Windows 7 64-bit
- Ubuntu 16.04 32-bit
 
[Steps to reproduce]:
1.Launch Firefox with clean profile.
2.Open about:config and create the pref xpinstall.signatures.dev-root then set it to true.
3.Install https://addons-dev.allizom.org/en-US/firefox/addon/themextensionv1-0/
4.Press on the Themextension icon.
 
 
[Expected results]:
- The Themextension updates the tab of the browser with different colors at a certain interval of time. 
- Here is a video: https://www.dropbox.com/s/pqxi3d6oxrjcrp8/Themextension1.gif?dl=0
 
[Actual results]:
- The Themextension doesn’t update the tab of the browser with different colors at a certain interval of time and an error is displayed in the browser console every time the Themextension tries to change the color.
- Here is a video:https://www.dropbox.com/s/jltr4lr9jakpfl7/ThemextensionXPI.gif?dl=0
 
[Additional notes]:
- This issue is reproducing all the time.
- Loaded locally in about:debugging with the files unzipped, the Themextension it works.

Here is a video:https://www.dropbox.com/s/pafz69xc6siqhi7/UnzippedThemex.gif?dl=0

- After you load in about:debugging a .xpi format file and you press on the Themextension icon, the browser console will display the same error as in the [Actual results].

Here is a video:https://www.dropbox.com/s/1ei96h8tv91lcaq/AboutDebugThemext.gif?dl=0

Comment 1

[Andy McKay]

Attachment: themextension-0.3.zip

This version uses alarms, not setInterval. It also removes the need to press the button because I'm inpatient :)

Comment 2

[Andy McKay]

Attachment: themextension-0.4.zip

Comment 3

[Andy McKay]

The original extension calls:

  browser.theme.update({
    images: {
      headerURL: "weather.png",
    },

No weather.png exists in the extension and it fails. It works when run unpacked through about:debugging, however when run as an .xpi we get an error message and the update fails:

[Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIWebBrowserPersist.saveURI]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: resource://gre/modules/LightweightThemeManager.jsm :: _persistImage :: line 877"  data: no]

Ideally we should try and make the behaviour between running unpacked and packed the same if possible.