1371597 - Rebase causes errors in mozeslint hook (when cset disappears)

Status: RESOLVED INCOMPLETE

(Developer Infrastructure :: Lint and Formatting, defect)

Description

[:Gijs (he/him)]

Platform: OS X

Console:

gijs-mbp:firefox-unified gkruitbosch$ hg wip
o     405935:7457b240847d cbook tip inbound
:\   Merge mozilla-central to mozilla-inbound
: \
: :\
+-----o   405820:f3b670b8cc32 ffxbld release
: : :    No bug, Automated blocklist update from host bld-linux64-spot-302 - a=blocklist-update
: : : o   405744:e371f313fd2d bhearsum
: : : |  bug 1359084: update balrog usernames in release configs. r=asasaki a=release
: : : ~
: : : o   405730:b503992caddb ffxbld esr45
: : : |  No bug, Automated blocklist update from host bld-linux64-spot-327 - a=blocklist-update
: : : ~
: : : @   405533:6c9e054ce0a9 gijskruitbosch
: : : |  Bug 1354109 - update WebExtensions code for Photon, r?kmag
: : : o   405530:8419dd9c3cb6 gijskruitbosch
: : : |  flip pref
: : : o   405529:923497f941fd gijskruitbosch
: : :/   Bug 1369564 - fix min-width issues with panels, r=mikedeboer
+---o   405495:7efda263a842 ryanvm
: :/   Merge inbound to m-c. a=merge
: : o   402353:e71f2d7cdc01 gijskruitbosch
: :/   Bug 1339329 - cert error time warnings should only appear for recent blocklists and if clock skew is sufficient to make cert valid, r?johannh
: o   402306:f9ca97a33429 archaeopteryx
:/   Backed out changeset 6411a4abcc1a (bug 1355311) for causing crash in mozilla::dom::TimeoutManager::MaybeStartThrottleTrackingTimout (bug 1366812). r=backout a=backout on a CLOSED TREE
: o   400566:d38398e5144e kmoir aurora
:/   Bug 1358976 - Stop automatic triggers of nightly builds on mozilla-aurora r=dustin DONTBUILD a=test-only CLOSED TREE
: o   360805:63abc7d8b264 gijskruitbosch
:/   WIP: docshell-chrome-stuff
o   360498:bfa85d23df57 wkocher
|  Backed out changeset 76bbb68f8441 (bug 1309187) for depending on bug 1309865 a=backout


gijs-mbp:firefox-unified gkruitbosch$ hg rebase -b . -d central
rebasing 405529:923497f941fd "Bug 1369564 - fix min-width issues with panels, r=mikedeboer"
merging browser/components/customizableui/PanelMultiView.jsm                                                                                                                                                        
note: rebase of 405529:923497f941fd created no changes to commit                                                                                                                                                    
rebasing 405530:8419dd9c3cb6 "flip pref"
merging browser/app/profile/firefox.js                                                                                                                                                                              
rebasing 405533:6c9e054ce0a9 "Bug 1354109 - update WebExtensions code for Photon, r?kmag"
merging browser/components/extensions/ext-browserAction.js                                                                                                                                                          
error: commit.eslint hook raised an exception: 'module' object has no attribute 'EXTENSIONS_RE'
(run with --traceback for stack trace)
error: commit.eslint hook raised an exception: 'module' object has no attribute 'EXTENSIONS_RE'
(run with --traceback for stack trace)


gijs-mbp:firefox-unified gkruitbosch$ hg wip
@   405937:43a91f791f86 gijskruitbosch tip
|  Bug 1354109 - update WebExtensions code for Photon, r?kmag
o   405936:988f12870b70 gijskruitbosch
|  flip pref
| o     405935:7457b240847d cbook inbound
|/:\   Merge mozilla-central to mozilla-inbound
o---+   405934:1742b1bdadd1 cbook central
:/ /   merge mozilla-inbound to mozilla-central a=merge
+---o   405820:f3b670b8cc32 ffxbld release
: :    No bug, Automated blocklist update from host bld-linux64-spot-302 - a=blocklist-update
: : o   405744:e371f313fd2d bhearsum
: : |  bug 1359084: update balrog usernames in release configs. r=asasaki a=release
: : ~
: : o   405730:b503992caddb ffxbld esr45
: : |  No bug, Automated blocklist update from host bld-linux64-spot-327 - a=blocklist-update
: : ~
: : o   402353:e71f2d7cdc01 gijskruitbosch
: :/   Bug 1339329 - cert error time warnings should only appear for recent blocklists and if clock skew is sufficient to make cert valid, r?johannh
: o   402306:f9ca97a33429 archaeopteryx
:/   Backed out changeset 6411a4abcc1a (bug 1355311) for causing crash in mozilla::dom::TimeoutManager::MaybeStartThrottleTrackingTimout (bug 1366812). r=backout a=backout on a CLOSED TREE
: o   400566:d38398e5144e kmoir aurora
:/   Bug 1358976 - Stop automatic triggers of nightly builds on mozilla-aurora r=dustin DONTBUILD a=test-only CLOSED TREE
: o   360805:63abc7d8b264 gijskruitbosch
:/   WIP: docshell-chrome-stuff
o   360498:bfa85d23df57 wkocher
|  Backed out changeset 76bbb68f8441 (bug 1309187) for depending on bug 1309865 a=backout
~

Comment 1

[Mark Banner (:standard8)]

This is probably a regression from bug 1288432. Andrew, any ideas?

Comment 2

[Andrew Halberstadt [:ahal]]

Hm, EXTENSIONS_RE only appears in hook_helper.py now, and nothing is trying to use it from another module. Gijs, is the problem reproducible after running |mach clobber python|? And it doesn't happen if you do a normal commit?

Comment 3

[Andrew Halberstadt [:ahal]]

Ftr I set up a rebase that would cause a changeset to disappear, and wasn't able to reproduce this.

Comment 4

[:Gijs (he/him)]

(In reply to Andrew Halberstadt [:ahal] from comment #2)
> Hm, EXTENSIONS_RE only appears in hook_helper.py now, and nothing is trying
> to use it from another module. Gijs, is the problem reproducible after
> running |mach clobber python|? And it doesn't happen if you do a normal
> commit?

I only saw this the once, so I'm not sure how to provide information here... should we just close this as incomplete?

Comment 5

[Andrew Halberstadt [:ahal]]

Maybe things can potentially go wonky if you rebase over changes that modify the hook itself. If that's the case, probably not much we can do about it. I'm happy to resolve incomplete for now.