Delay getting the search component service until the first StartSearch

RESOLVED FIXED in Firefox 60

Status

()

enhancement
P2
normal
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: mak, Assigned: florian)

Tracking

(Blocks 1 bug)

55 Branch
mozilla60
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox60 fixed)

Details

(Whiteboard: [fxsearch])

Attachments

(1 attachment)

We currently initialize the search component on setInput, that means basically when we attach the controller. That means we initialize the location bar search component when the location bar gets focus, for example.

That should not be necessary until the user starts searching. We could probably try to do that lazily from StartSearch by checking mSearches.Length().
(Assignee)

Updated

a year ago
Blocks: 1403648
(Assignee)

Updated

a year ago
Assignee: nobody → florian
Status: NEW → ASSIGNED
Comment on attachment 8949102 [details] [diff] [review]
Patch

Review of attachment 8949102 [details] [diff] [review]:
-----------------------------------------------------------------

It looks great. I checked that all the relevant properties are still initialized in a timely manner, I didn't identify any issues with that. Thanks!
Attachment #8949102 - Flags: review?(mak77) → review+

Comment 3

a year ago
Pushed by florian@queze.net:
https://hg.mozilla.org/integration/mozilla-inbound/rev/789903045a39
Delay getting the search component service until the first StartSearch, r=mak.
https://hg.mozilla.org/mozilla-central/rev/789903045a39
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.