Pop-ups not displayed if never show checkbox left unmarked
Categories
(Firefox for Android Graveyard :: General, defect, P2)
Tracking
(firefox54 wontfix, firefox55 wontfix, firefox67 wontfix, firefox67.0.1 wontfix, firefox68 verified, firefox69 verified)
People
(Reporter: u549602, Assigned: andrei.a.lazar)
References
Details
(Whiteboard: [bcs:p2])
Attachments
(1 file)
47 bytes,
text/x-phabricator-request
|
jcristau
:
approval-mozilla-beta+
|
Details | Review |
Build: 55.0a1 Device: Alcatel 1+ (Android 6.0.1) STR: 1. Go to http://www.popuptest.com/popuptest1.html 2. In the pop-up prevention screen leave "Don't ask again for this site" checkbox unmarked 3. Tap Show Expected result: Pop-ups should be displayed Actual result: Pop-ups are not displayed For further details please check https://pastebin.mozilla.org/9024056 and https://www.youtube.com/watch?v=Mi4rOlK49N4
Comment 1•6 years ago
|
||
Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195 Needinfo :susheel if you think this bug should be re-triaged.
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 2•5 years ago
|
||
Added the missing data to the UpdateBlockedPopups event fired from PopupBlockingChild component.
Assignee | ||
Updated•5 years ago
|
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/425942abf9fd
Pop-ups not displayed if never show checkbox left unmarked r=johannh,petru
Assignee | ||
Comment 4•5 years ago
|
||
Comment on attachment 9065031 [details]
Bug 1371618 Pop-ups not displayed if never show checkbox left unmarked r=JanH
Beta/Release Uplift Approval Request
- User impact if declined: Popups blocker won't work as expected.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): The solution is simple and small and the whole functionality was already implemented.
- String changes made/needed:
Comment 5•5 years ago
|
||
Comment on attachment 9065031 [details]
Bug 1371618 Pop-ups not displayed if never show checkbox left unmarked r=JanH
fennec fix, approved for beta68
Comment 6•5 years ago
|
||
bugherder |
Comment 7•5 years ago
|
||
Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.
Updated•5 years ago
|
Comment 8•5 years ago
|
||
bugherder uplift |
Verified with device Lenovo TB3-850M (Android 6.0.0) on Firefox Beta 68.0b7 and Firefox Nightly 68.0a1 (2019-06-03) with status fixed.
I will mark the ticket Verified - Fixed.
Updated•3 years ago
|
Description
•