Status

Testing
Lint
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: past, Assigned: past)

Tracking

Version 3
mozilla56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

4 months ago
npm 5 was recently released and it comes with mozilla-build 3.0pre2 and node 8. Using it requires updating npm-shrinkwrap.json and package.json, otherwise these files appear locally modified. I will post the patch in a minute, but I haven't tested if these files work with an older npm installation.
Comment hidden (mozreview-request)
(Assignee)

Comment 2

4 months ago
It seems to work fine on a system with npm 3.10.10.
Comment hidden (mozreview-request)
(Assignee)

Updated

4 months ago
Assignee: nobody → past
Status: NEW → ASSIGNED
I triggered a try build to check that it is happy with this. There's a couple of things I'll need to look into next week as well.

Comment 5

4 months ago
mozreview-review
Comment on attachment 8876121 [details]
Bug 1371669 - Add support for npm 5.

https://reviewboard.mozilla.org/r/147552/#review152378

Ok, this seems to run alright, lets try it in the wild :-)
Attachment #8876121 - Flags: review?(standard8) → review+

Comment 6

4 months ago
Pushed by pastithas@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/587a778f99bc
Add support for npm 5. r=standard8

Comment 7

4 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/587a778f99bc
Status: ASSIGNED → RESOLVED
Last Resolved: 4 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.