Closed
Bug 1371669
Opened 7 years ago
Closed 7 years ago
Support npm 5
Categories
(Developer Infrastructure :: Lint and Formatting, enhancement)
Tracking
(firefox56 fixed)
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: past, Assigned: past)
Details
Attachments
(1 file)
npm 5 was recently released and it comes with mozilla-build 3.0pre2 and node 8. Using it requires updating npm-shrinkwrap.json and package.json, otherwise these files appear locally modified. I will post the patch in a minute, but I haven't tested if these files work with an older npm installation.
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•7 years ago
|
||
It seems to work fine on a system with npm 3.10.10.
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → past
Status: NEW → ASSIGNED
Comment 4•7 years ago
|
||
I triggered a try build to check that it is happy with this. There's a couple of things I'll need to look into next week as well.
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8876121 [details] Bug 1371669 - Add support for npm 5. https://reviewboard.mozilla.org/r/147552/#review152378 Ok, this seems to run alright, lets try it in the wild :-)
Attachment #8876121 -
Flags: review?(standard8) → review+
Pushed by pastithas@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/587a778f99bc Add support for npm 5. r=standard8
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/587a778f99bc
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Updated•6 years ago
|
Product: Testing → Firefox Build System
Updated•5 years ago
|
Version: Version 3 → 3 Branch
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•