Closed Bug 1371669 Opened 2 years ago Closed 2 years ago

Support npm 5

Categories

(Firefox Build System :: Lint and Formatting, enhancement)

3 Branch
enhancement
Not set

Tracking

(firefox56 fixed)

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: past, Assigned: past)

Details

Attachments

(1 file)

npm 5 was recently released and it comes with mozilla-build 3.0pre2 and node 8. Using it requires updating npm-shrinkwrap.json and package.json, otherwise these files appear locally modified. I will post the patch in a minute, but I haven't tested if these files work with an older npm installation.
It seems to work fine on a system with npm 3.10.10.
Assignee: nobody → past
Status: NEW → ASSIGNED
I triggered a try build to check that it is happy with this. There's a couple of things I'll need to look into next week as well.
Comment on attachment 8876121 [details]
Bug 1371669 - Add support for npm 5.

https://reviewboard.mozilla.org/r/147552/#review152378

Ok, this seems to run alright, lets try it in the wild :-)
Attachment #8876121 - Flags: review?(standard8) → review+
https://hg.mozilla.org/mozilla-central/rev/587a778f99bc
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Product: Testing → Firefox Build System
Version: Version 3 → 3 Branch
You need to log in before you can comment on or make changes to this bug.