1371687 - Remove UpdateShortcutAppUserModelIds from helper.exe

Status: RESOLVED FIXED

(Firefox :: Installer, task, P3)

Description

[Molly Howell (she/her) (mostly inactive)]

Bug 692295 is removing the code that invokes helper.exe with the /UpdateShortcutAppUserModelIds option. That means we can remove the option.

Comment 1

[Zheng Li]

Hi, this is my first time attempting to make contributions to Mozilla. I finished setting up the dev environment in a VM. If no one is working on this could I take it please?

Comment 2

[Molly Howell (she/her) (mostly inactive)]

Thanks for offering to help out! No one is working on this, so I'll assign you to it.

Please request review from me (mhowell) when you have a patch ready. Since you have an environment set up already, I assume you've seen our Getting Started guide, but there it is just in case. If you need any help working through the process of submitting the patch, our IRC channel #introduction can help, or you can ask here and I can answer questions.

For the patch itself, the code that should be removed is these lines.

Thanks again!

Comment 3

[Molly Howell (she/her) (mostly inactive)]

Hi, Zheng. Do you still intend to work on this bug? There's been no activity here for a week, and others are looking to get involved here.

Comment 4

[Molly Howell (she/her) (mostly inactive)]

It's been a couple of days and I haven't heard back, so I'm changing the assignment to another person who's looking to get involved.

Comment 5

[Taylor Southorn]

Attachment: Bug 1371687 - Remove UpdateShortcutAppUserModelIds from helper.exe. r=mhowell

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/307626105c39
Remove UpdateShortcutAppUserModelIds from helper.exe. r=mhowell

Comment 7

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/307626105c39