Closed Bug 1371687 Opened 3 years ago Closed 2 months ago

Remove UpdateShortcutAppUserModelIds from helper.exe

Categories

(Firefox :: Installer, task, P3)

Unspecified
Windows
task

Tracking

()

RESOLVED FIXED
Firefox 72
Tracking Status
firefox72 --- fixed

People

(Reporter: mhowell, Assigned: southort)

References

Details

(Keywords: good-first-bug)

Attachments

(1 file)

Bug 692295 is removing the code that invokes helper.exe with the /UpdateShortcutAppUserModelIds option. That means we can remove the option.
Type: enhancement → task
Keywords: good-first-bug
OS: Unspecified → Windows

Hi, this is my first time attempting to make contributions to Mozilla. I finished setting up the dev environment in a VM. If no one is working on this could I take it please?

Thanks for offering to help out! No one is working on this, so I'll assign you to it.

Please request review from me (mhowell) when you have a patch ready. Since you have an environment set up already, I assume you've seen our Getting Started guide, but there it is just in case. If you need any help working through the process of submitting the patch, our IRC channel #introduction can help, or you can ask here and I can answer questions.

For the patch itself, the code that should be removed is these lines.

Thanks again!

Assignee: nobody → zhengnan.li
Status: NEW → ASSIGNED

Hi, Zheng. Do you still intend to work on this bug? There's been no activity here for a week, and others are looking to get involved here.

Flags: needinfo?(zhengnan.li)

It's been a couple of days and I haven't heard back, so I'm changing the assignment to another person who's looking to get involved.

Assignee: zhengnan.li → southort
Flags: needinfo?(zhengnan.li)
Pushed by mhowell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/307626105c39
Remove UpdateShortcutAppUserModelIds from helper.exe. r=mhowell
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72
You need to log in before you can comment on or make changes to this bug.