1371707 - Fix Travis dependencies for Linux x86

Status: RESOLVED FIXED

(Testing :: geckodriver, enhancement)

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1371707 - Fix Linux x86 packages on Travis for geckodriver;

It is not clear exactly why, but Travis will complain that gcc and
gcc-multilib packages cannot be installed because they are virtual.  The
working theory is that the virtual packages do not correctly resolve to
the concrete gcc-4.8 and gcc-4.8-multilib packages.

This patch fixes compilation of geckodriver on Travis, which we at the
moment use for releasing geckodriver.

DONTBUILD

Review commit: https://reviewboard.mozilla.org/r/147600/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/147600/

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Can you please link to the failure?

Comment 3

[Andreas Tolfsen ❲:ato❳]

(In reply to Henrik Skupin (:whimboo) from comment #2)
> Can you please link to the failure?

https://travis-ci.org/mozilla/geckodriver/jobs/241215030

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8876184 [details]
Bug 1371707 - Fix Linux x86 packages on Travis for geckodriver;

https://reviewboard.mozilla.org/r/147600/#review152870

::: testing/geckodriver/.travis.yml:13
(Diff revision 1)
>  before_install:
>    - if [[ "$NAME" == "linux32" ]]; then
>      sudo dpkg --purge build-essential libtool;
>      sudo apt-get -qq update;
> -    sudo apt-get -yq --force-yes install libstdc++6:i386 libbz2-dev:i386 gcc-multilib:i386 musl-tools:i386; fi
> -    
> +    sudo apt-get -yq --force-yes install libstdc++6:i386 libbz2-dev:i386 gcc-4.8:i386 gcc-4.8-multilib:i386 musl-tools:i386 binutils:i386; fi
> +

It looks like you hit https://github.com/travis-ci/travis-ci/issues/5670 here. Does updating `gcc` first as described in this issue fixes the problem?

I would love to have the virtual packages listed here, so that we do not have to update this once in a while.

But if this code only exists until we can build everything in tree via Taskcluster, we might wanna get this landed as is.

Comment 5

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8876184 [details]
Bug 1371707 - Fix Linux x86 packages on Travis for geckodriver;

https://reviewboard.mozilla.org/r/147600/#review152870

> It looks like you hit https://github.com/travis-ci/travis-ci/issues/5670 here. Does updating `gcc` first as described in this issue fixes the problem?
> 
> I would love to have the virtual packages listed here, so that we do not have to update this once in a while.
> 
> But if this code only exists until we can build everything in tree via Taskcluster, we might wanna get this landed as is.

I would quite like to get this landed as-is.  Maintaining the Travis build environment is not a priority, and I don’t have any extra time to spend on this.  If you do, you’re welcome to follow up on this and submit a patch.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8876184 [details]
Bug 1371707 - Fix Linux x86 packages on Travis for geckodriver;

https://reviewboard.mozilla.org/r/147600/#review152870

> I would quite like to get this landed as-is.  Maintaining the Travis build environment is not a priority, and I don’t have any extra time to spend on this.  If you do, you’re welcome to follow up on this and submit a patch.

Sure. And I still assume it's only used for the moment until we can build all in tree.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8876184 [details]
Bug 1371707 - Fix Linux x86 packages on Travis for geckodriver;

https://reviewboard.mozilla.org/r/147600/#review152912

Comment 8

[Andreas Tolfsen ❲:ato❳]

(In reply to Henrik Skupin (:whimboo) from comment #6)

> > I would quite like to get this landed as-is.  Maintaining the Travis
> > build environment is not a priority, and I don’t have any extra
> > time to spend on this.  If you do, you’re welcome to follow up on
> > this and submit a patch.
> 
> Sure. And I still assume it's only used for the moment until we can
> build all in tree.

Yes, precisely.  I want us to get to the point where we can
release to GitHub from in-tree, but we are currently lacking
some platforms and some infrastructure to do that.  I filed
https://bugzilla.mozilla.org/show_bug.cgi?id=1372587 to track this.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/41d5632628a6
Fix Linux x86 packages on Travis for geckodriver; r=whimboo

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/41d5632628a6