1371718 - Recommend Firefox 53 or greater in README

Status: RESOLVED FIXED

(Testing :: geckodriver, enhancement)

Description

[Andreas Tolfsen ❲:ato❳]

We should recommend a release channel build.

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1371718 - Recommend Firefox 53 or greater for geckodriver;

DONTBUILD

Review commit: https://reviewboard.mozilla.org/r/147628/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/147628/

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

Comment on attachment 8876191 [details]
Bug 1371718 - Recommend Firefox 53 or greater for geckodriver;

https://reviewboard.mozilla.org/r/147628/#review151936

::: testing/geckodriver/README.md:42
(Diff revision 1)
>  [Selenium](https://github.com/mozilla/geckodriver/issues?q=is%3Aissue+is%3Aopen+label%3Aselenium),
>  and [specification](https://github.com/mozilla/geckodriver/issues?q=is%3Aissue+is%3Aopen+label%3Aspec)
>  problems in our
>  [issue tracker](https://github.com/mozilla/geckodriver/issues).
>  
> -Support is best in Firefox 52.0.3 and onwards,
> +Support is best in Firefox 53.0.3 and greater,

To avoid us to look for security releases, I would propose that we only mention the main version like 53 here.

::: testing/geckodriver/README.md:48
(Diff revision 1)
>  although generally the more recent the Firefox version,
>  the better the experience as they have more bug fixes and features.
>  Some features will only be available in the most recent Firefox versions,
>  and we strongly advise using the [latest Firefox Nightly](https://nightly.mozilla.org/) with geckodriver.
> -Since Windows XP support in Firefox will be dropped with Firefox 53,
> -we do not support this platform.
> +geckodriver is not available on Windows XP
> +because Firefox 53 dropped support fo this platform.

I feel this reads better:

Since Windows XP support was dropped with Firefox 53.0, geckodriver is not supported on this platform.

Comment 3

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8876191 [details]
Bug 1371718 - Recommend Firefox 53 or greater for geckodriver;

https://reviewboard.mozilla.org/r/147628/#review151936

> To avoid us to look for security releases, I would propose that we only mention the main version like 53 here.

OK.

Comment 4

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8876191 [details]
Bug 1371718 - Recommend Firefox 53 or greater for geckodriver;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/147628/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a4dc441d1bba
Recommend Firefox 53 or greater for geckodriver; r=whimboo

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a4dc441d1bba