Closed Bug 1371745 Opened 7 years ago Closed 6 years ago

Should have copy/pastable hg pull/import revs in show_bug.cgi again for mozreview requests

Categories

(Conduit :: General, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: Gijs, Unassigned)

Details

When reviewing patches, or checking they work on different OSes, I often need to pull or import patches from bugzilla/mozreview.

For non-mozreview patches, I can use qimportbz, so "hg import bz://<bugnumber>" works (though I think that only works for single patches, and only 'qimport' followed by 'qfin -a' would work for multiple patches, unless that got fixed separately...).

For non-mozreview patches, this doesn't work. Instead, I have to click the final item in the patch series and then copy-paste the hg pull/import bits from there.

This workflow would be quicker if there were revs and/or hg pull/import lines I could copy/paste directly in bugzilla, instead of in mozreview (which is usually slow...) and/or if we updated importbz to be able to deal with mozreview patches. It's likely that we would need to update it (again) for phabricator integration if/when we do that, but I don't know enough about how that will work to know if that means working on this beforehand is going to be wasted effort.

Also CC'ing :glob and :mcote in case they know about our longer-term plans for code review here and what would be the 'best' path forward for smoothing out the "I have this bug number, give me patches in my local tree" workflow. Feel free to morph this bug accordingly.
I'll let mcote attempt to triage this before commiting to working on it.
Status: NEW → UNCONFIRMED
Ever confirmed: false
Flags: needinfo?(mcote)
I assume you mean "For mozreview patches" in your third paragraph. :)

Given MozReview is in maintenance mode until the switch to Phabricator, I'm going to move this over to the Conduit product, to be considered when we (re)implement the push/commit model (I do agree this should be made as easy as feasible).  In the interim, after launch users will be able to use the "arc patch" command to apply Phabricator patches locally.
Status: UNCONFIRMED → NEW
Component: Extensions: Review → General
Ever confirmed: true
Flags: needinfo?(mcote)
Product: bugzilla.mozilla.org → Conduit
Version: Production → unspecified
"arc patch" is the way to go; it runs on the command line and only requires a revision number.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.