1371746 - Remove unused variables in constants.js

Status: RESOLVED FIXED

(Firefox :: Sync, enhancement, P3)

Description

[Edouard Oger [:eoger]]

We have a lot of unused stuff in services/sync/modules/constants.js, this should be easy to clean-up.

Comment 1

[Luciano I]

Attachment: Bug 1371746 - Remove unused variables in constants.js.

Review commit: https://reviewboard.mozilla.org/r/163234/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/163234/

Comment 2

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8892288 [details]
Bug 1371746 - Remove unused variables in constants.js.

https://reviewboard.mozilla.org/r/163234/#review168568

Looks great, thanks!

Comment 3

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8892288 [details]
Bug 1371746 - Remove unused variables in constants.js.

https://reviewboard.mozilla.org/r/163234/#review168610

Try looks good, but there's a typo in the commit message - could you please fix that and re-push it to mozreview, and I'll land it.

Comment 4

[Luciano I]

Comment on attachment 8892288 [details]
Bug 1371746 - Remove unused variables in constants.js.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/163234/diff/1-2/

Comment 5

[Lina Butler (ex-Mozilla)]

Comment on attachment 8892288 [details]
Bug 1371746 - Remove unused variables in constants.js.

https://reviewboard.mozilla.org/r/163234/#review168894

::: commit-message-8b196:1
(Diff revision 2)
> +Bug 1371746 - Remove unused variables in constanstjs. r?markh

Typo: "constants.js". Fix that up and I'll land this for you! \o/

Comment 6

[Luciano I]

Comment on attachment 8892288 [details]
Bug 1371746 - Remove unused variables in constants.js.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/163234/diff/2-3/

Comment 7

[Lina Butler (ex-Mozilla)]

Comment on attachment 8892288 [details]
Bug 1371746 - Remove unused variables in constants.js.

https://reviewboard.mozilla.org/r/163234/#review168910

Thanks!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/749d2dbd5040
Remove unused variables in constants.js. r=kitcambridge

Comment 9

[Luciano I]

i found that i forget to remove unused variables of here:
http://searchfox.org/mozilla-central/source/tools/lint/eslint/modules.json#34

maybe, that is the problem?

and this two variables are use but no from constants.js:
http://searchfox.org/mozilla-central/search?q=HMAC_INPUT&case=false&regexp=false&path=
http://searchfox.org/mozilla-central/search?q=FIREFOX_ID&case=false&regexp=false&path=

remove anyway?

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/749d2dbd5040

Comment 11

[Mark Hammond [:markh] [:mhammond]]

(In reply to Luciano I from comment #9)
> i found that i forget to remove unused variables of here:
> http://searchfox.org/mozilla-central/source/tools/lint/eslint/modules.json#34
> 
> maybe, that is the problem?
> 
> and this two variables are use but no from constants.js:
> http://searchfox.org/mozilla-central/
> search?q=HMAC_INPUT&case=false&regexp=false&path=
> http://searchfox.org/mozilla-central/
> search?q=FIREFOX_ID&case=false&regexp=false&path=
> 
> remove anyway?

Thanks for following up here - please feel free to open another bug for these changes!