1371762 - Legacy page shows an experiment

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect, P3)

Description

[Andy McKay]

On Nightly

1. install a legacy extension
2. install a webextensions experiment
3. turn on the legacy extension pref
4. note that the webextensions experiment appears in the legacy page

This will never happen in release, so prioritize accordingly.

This will only occur if you have at least one legacy extension.

Comment 1

[Andrew Swan [:aswan]]

To be clear, step 3 actually means legacy extensions should be disabled right?

I think I might be missing something but experiments are bootstrapped addons so if they are not signed with "Mozilla Extensions" and legacy extensions are disabled, this sounds like everything is working as intended.

Comment 2

[Andy McKay]

But from what I can tell, it hasn't been disabled.

Comment 3

[:shell escalante]

the experiment not being disabled is surprising.  why not and does this impact something else.

Comment 4

[Andrew Swan [:aswan]]

Attachment: Bug 1371762 Part 1 Let cert shim code selectively identify some xpis as privileged

Also try to clarify constsants referring to internal vs external
addon types.

Review commit: https://reviewboard.mozilla.org/r/150004/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/150004/

Comment 5

[Andrew Swan [:aswan]]

Attachment: Bug 1371762 Part 2 Treat webextension experiments as legacy

Review commit: https://reviewboard.mozilla.org/r/158870/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/158870/

Comment 6

[Andrew Swan [:aswan]]

Comment on attachment 8878696 [details]
Bug 1371762 Part 1 Let cert shim code selectively identify some xpis as privileged

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/150004/diff/1-2/

Comment 7

[Robert Helmer [:rhelmer]]

Comment on attachment 8878696 [details]
Bug 1371762 Part 1 Let cert shim code selectively identify some xpis as privileged

https://reviewboard.mozilla.org/r/150004/#review164894

Comment 8

[Robert Helmer [:rhelmer]]

Comment on attachment 8887996 [details]
Bug 1371762 Part 2 Treat webextension experiments as legacy

https://reviewboard.mozilla.org/r/158870/#review164896

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/47ebbbac4f99
Part 1 Let cert shim code selectively identify some xpis as privileged r=rhelmer
https://hg.mozilla.org/integration/autoland/rev/7255faf1c8a4
Part 2 Treat webextension experiments as legacy r=rhelmer

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/47ebbbac4f99
https://hg.mozilla.org/mozilla-central/rev/7255faf1c8a4