Create new build platform for OSX 10.10

RESOLVED WONTFIX

Status

Release Engineering
General Automation
P3
normal
RESOLVED WONTFIX
4 months ago
4 months ago

People

(Reporter: catlee, Assigned: catlee)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments, 2 obsolete attachments)

(Assignee)

Description

4 months ago
We need to support building both on 10.7 and 10.10 for some amount of time. This means we need a separate platform in buildbot for 10.10.

Initially we'll have builds available only on try, off by default.

Would 'macosx64-1010' work as a base platform name?
(Assignee)

Comment 1

4 months ago
Created attachment 8876765 [details] [diff] [review]
Add 'macosx64-yosemite' to try
Assignee: nobody → catlee
Attachment #8876765 - Flags: review?(rail)
(Assignee)

Comment 2

4 months ago
Created attachment 8876766 [details] [diff] [review]
patch for buildslaves.py on build masters
Attachment #8876766 - Flags: review?(rail)
Attachment #8876766 - Flags: review?(rail) → review+
Comment on attachment 8876765 [details] [diff] [review]
Add 'macosx64-yosemite' to try

Review of attachment 8876765 [details] [diff] [review]:
-----------------------------------------------------------------

Probably you should skip one of the hunks, see below.

::: mozilla/BuildSlaves.py.template
@@ +7,5 @@
>          'win64-rev2': 'pass',
>          'try-win32': 'pass',
>          'macosx64': 'pass',
>          'macosx64-lion': 'pass',
> +        'macosx64-yosemite': 'pass',

Probably it's worth adding the new platform to https://hg.mozilla.org/build/buildbotcustom/file/tip/common.py#l56 as well

::: mozilla/config.py
@@ -1882,5 @@
> -PLATFORM_VARS["macosx64-lion-debug"] = deepcopy(PLATFORM_VARS["macosx64-debug"])
> -PLATFORM_VARS["macosx64-lion"]["base_name"] = 'OS X 10.7 %(branch)s'
> -PLATFORM_VARS["macosx64-lion-debug"]["base_name"] = 'OS X 10.7 64-bit %(branch)s leak test'
> -PLATFORM_VARS["macosx64-lion"]["slaves"] = SLAVES['macosx64-lion']
> -PLATFORM_VARS["macosx64-lion-debug"]["slaves"] = SLAVES['macosx64-lion']

I think we still need this for fuzzing. Not 100% sure, but it'd be safer to skip this hunk.

@@ -3006,5 @@
>          PROJECTS[branch_project_name] = project
>  
> -# ant test on try
> -## ant rides the trains (Bug 971841)
> -# for name, branch in items_before(BRANCHES, 'gecko_version', 30):

DIAF!
Attachment #8876765 - Flags: review?(rail) → review+
(Assignee)

Comment 4

4 months ago
https://hg.mozilla.org/build/puppet/rev/2519e9e2f159c2ef3cc52320b7ae001869e4da9a
Bug 1371776: Add macosx64-yosemite to BuildSlaves.py r=rail
(Assignee)

Comment 5

4 months ago
Created attachment 8876815 [details] [diff] [review]
Add 'macosx64-yosemite' to try

I just fixed up the naming scheme.

Confirmed that we don't need those hunks for fuzzing.
Attachment #8876765 - Attachment is obsolete: true
Attachment #8876815 - Flags: review?(rail)
(Assignee)

Comment 6

4 months ago
Comment on attachment 8876815 [details] [diff] [review]
Add 'macosx64-yosemite' to try

going to remove the debug builders
Attachment #8876815 - Attachment is obsolete: true
Attachment #8876815 - Flags: review?(rail)
(Assignee)

Comment 7

4 months ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f4d78c07ded7
Comment hidden (mozreview-request)
(Assignee)

Comment 9

4 months ago
Created attachment 8876842 [details] [diff] [review]
Add 'macosx64-yosemite' to try
Attachment #8876842 - Flags: review?(rail)
(Assignee)

Updated

4 months ago
Attachment #8876840 - Flags: review?(wcosta)
Attachment #8876842 - Flags: review?(rail) → review+

Comment 10

4 months ago
mozreview-review
Comment on attachment 8876840 [details]
Bug 1371776: Get OSX 10.10 builds working on try

https://reviewboard.mozilla.org/r/148168/#review152930
Attachment #8876840 - Flags: review?(wcosta) → review+
(Assignee)

Comment 11

4 months ago
Back burner for now; we're hoping the TC cross-compiled builds work out.
Severity: major → normal
Priority: P1 → P3
(Assignee)

Comment 12

4 months ago
We're going ahead with the cross-compiled builds.
Status: NEW → RESOLVED
Last Resolved: 4 months ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.