1371801 - Detect if a page can be viewed in reader mode

Status: RESOLVED DUPLICATE of bug 1381992

(WebExtensions :: Untriaged, enhancement, P5)

Description

[Andy McKay]

It would be nice if we could detect if a page has reader mode available or not, since not all pages have this. Perhaps we could add this to the tab API or maybe in the tabs.Tab object.

Comment 1

[Caitlin Neiman [:caitmuenster]]

Hi Andy, I've added this to the agenda for the June 20 WebExtension APIs triage meeting. 

Wiki: https://wiki.mozilla.org/Add-ons/Contribute/Triage#Next_Meeting

Agenda: https://docs.google.com/document/d/1s2j85VfYKTDftppFU-K7pgRs6sEuMTHVXqf3RL5iYvs/edit#

Comment 2

[Bob Silverberg [:bsilverberg]]

The internal function that does this in ReaderMode.jsm is called isProbablyReaderable [1], so I would be inclined to use this as the name for our API property as well. It implies that document is probably able to be put into reader mode, but does not guarantee it. It makes sense to make this a property of the Tab object.

Any comments on this?

[1] http://searchfox.org/mozilla-central/rev/cd82cacec2cf734768827ff85ba2dba90a534c5e/toolkit/components/reader/ReaderMode.jsm#184

Comment 3

[Bob Silverberg [:bsilverberg]]

Attachment: Bug 1371801 - Detect if a page can be viewed in reader mode,

This adds a hasReaderMode function to the tabs API which reports back
true or false.

Review commit: https://reviewboard.mozilla.org/r/177770/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/177770/

Comment 4

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8906017 [details]
Bug 1371801 - Detect if a page can be viewed in reader mode,

https://reviewboard.mozilla.org/r/177770/#review182846

Lets wait to land until we have a little more reader support.

Comment 5

[Bob Silverberg [:bsilverberg]]

Duping this to bug 1381992 so I can land everything at once.