Emulator telnet verification is unnecessary

RESOLVED FIXED in Firefox 55

Status

()

Firefox for Android
Testing
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: gbrown, Assigned: gbrown)

Tracking

Trunk
Firefox 56
Points:
---

Firefox Tracking Flags

(firefox55 fixed, firefox56 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
When mozharness starts the android emulator, it telnets to the emulator command interface and issues some status commands. That was put it as an additional verification of emulator health, but it never seems to fail -- not much value there. Plus, this gets more difficult in more modern emulators, which require authentication. Let's remove this code, and save some time on startup.
(Assignee)

Comment 2

a year ago
Created attachment 8876289 [details] [diff] [review]
eliminate telnet verification

No rush here. I'll check in after my pto.
Attachment #8876289 - Flags: review?(jmaher)
Comment on attachment 8876289 [details] [diff] [review]
eliminate telnet verification

Review of attachment 8876289 [details] [diff] [review]:
-----------------------------------------------------------------

nice cleanup
Attachment #8876289 - Flags: review?(jmaher) → review+

Comment 4

a year ago
Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4c151c84cfea
Eliminate android emulator telnet verification; r=jmaher

Comment 5

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/4c151c84cfea
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56

Comment 6

a year ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/b1b3ca173f7a
status-firefox55: --- → fixed
You need to log in before you can comment on or make changes to this bug.