Closed
Bug 1371805
Opened 8 years ago
Closed 8 years ago
Emulator telnet verification is unnecessary
Categories
(Firefox for Android Graveyard :: Testing, enhancement)
Firefox for Android Graveyard
Testing
Tracking
(firefox55 fixed, firefox56 fixed)
RESOLVED
FIXED
Firefox 56
People
(Reporter: gbrown, Assigned: gbrown)
Details
Attachments
(1 file)
|
3.19 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
When mozharness starts the android emulator, it telnets to the emulator command interface and issues some status commands. That was put it as an additional verification of emulator health, but it never seems to fail -- not much value there. Plus, this gets more difficult in more modern emulators, which require authentication. Let's remove this code, and save some time on startup.
|
Assignee | |
Comment 1•8 years ago
|
||
|
|
Assignee | |
Comment 2•8 years ago
|
||
No rush here. I'll check in after my pto.
Attachment #8876289 -
Flags: review?(jmaher)
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8876289 [details] [diff] [review]
eliminate telnet verification
Review of attachment 8876289 [details] [diff] [review]:
-----------------------------------------------------------------
nice cleanup
Attachment #8876289 -
Flags: review?(jmaher) → review+
Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4c151c84cfea
Eliminate android emulator telnet verification; r=jmaher
|
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
|
||
Comment 6•8 years ago
|
||
| bugherder uplift | ||
status-firefox55:
--- → fixed
|
||
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•