Closed Bug 1371805 Opened 2 years ago Closed 2 years ago

Emulator telnet verification is unnecessary

Categories

(Firefox for Android :: Testing, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
Firefox 56
Tracking Status
firefox55 --- fixed
firefox56 --- fixed

People

(Reporter: gbrown, Assigned: gbrown)

Details

Attachments

(1 file)

When mozharness starts the android emulator, it telnets to the emulator command interface and issues some status commands. That was put it as an additional verification of emulator health, but it never seems to fail -- not much value there. Plus, this gets more difficult in more modern emulators, which require authentication. Let's remove this code, and save some time on startup.
No rush here. I'll check in after my pto.
Attachment #8876289 - Flags: review?(jmaher)
Comment on attachment 8876289 [details] [diff] [review]
eliminate telnet verification

Review of attachment 8876289 [details] [diff] [review]:
-----------------------------------------------------------------

nice cleanup
Attachment #8876289 - Flags: review?(jmaher) → review+
Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4c151c84cfea
Eliminate android emulator telnet verification; r=jmaher
https://hg.mozilla.org/mozilla-central/rev/4c151c84cfea
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
You need to log in before you can comment on or make changes to this bug.