Automatically select the "fixed by commit" classification type if I paste something that looks like what a "fixed by commit" classification looks like

RESOLVED FIXED

Status

Tree Management
Treeherder
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: KWierso, Assigned: KWierso)

Tracking

Details

Attachments

(1 attachment)

47 bytes, text/x-github-pull-request
camd
: review+
Details | Review | Splinter Review
(Assignee)

Description

4 months ago
I've been marking a lot of things as "fixed by commit" here lately, and I want to make this as streamlined as possible to enable my laziness. :)

If I select the classification textbox and paste in something that looks like what should be in the textbox to classify a failure as "fixed by commit", Treeherder should be smart enough to do that for me.

Conditions I think qualify:
I paste a 12 character string containing nothing but a-f,0-9. (The 12 characters shown next to each commit in Treeherder)

I paste a 40 character string containing nothing but a-f,0-9. (The 40 characters that are the full-length references to a commit in Mercurial)

I paste a url containing the string "hg.mozilla.org". (I copy a link to a commit from one tree and paste that into a classification on another tree)


Patch forthcoming.
(Assignee)

Updated

4 months ago
Assignee: nobody → wkocher
(Assignee)

Comment 1

4 months ago
Created attachment 8876279 [details] [review]
PR2549
(Assignee)

Updated

4 months ago
Attachment #8876279 - Flags: review?(emorley)

Comment 2

4 months ago
Comment on attachment 8876279 [details] [review]
PR2549

I've left some comments on the PR :-)
Attachment #8876279 - Flags: review?(emorley) → review-
(Assignee)

Updated

4 months ago
Attachment #8876279 - Flags: review- → review?(emorley)

Comment 3

4 months ago
Comment on attachment 8876279 [details] [review]
PR2549

Cam - don't suppose you'd mind taking a look at this one? I trust you more than me :-)
Attachment #8876279 - Flags: review?(emorley) → review?(cdawson)

Updated

4 months ago
Attachment #8876279 - Flags: review?(cdawson) → review+

Comment 4

4 months ago
Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/acc65771fcfad592864e6298d3269a7fb0a681e3
Bug 1371820 - Automatically select 'fixed by commit' classification type in certain circumstances (#2549) r=emorley/camd

* Bug 1371820 - Automatically select 'fixed by commit' classification type in certain circumstances

If a 12 or 40 char string consisting only of a-f,0-9 is pasted into the classification textbox, or if the pasted string contains 'hg.mozilla.org', automatically select the 'fixed by commit' classification type, to reduce the number of clicks needed to properly classify this failure.
(Assignee)

Updated

4 months ago
Status: NEW → RESOLVED
Last Resolved: 4 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.