Add explicit API to set Debugging.failTestsOnAutoClose

RESOLVED FIXED in Firefox 56

Status

()

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

unspecified
mozilla56
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

2 years ago
test_sqlite.js sets a property on the Debugging object on the global in Sqlite.jsm like this:
  Cu.getGlobalForObject(Sqlite).Debugging.failTestsOnAutoClose = enabled;

With JSM global merging (bug 1186409), the Debugging object will be on a special per-JSM object, not the global, so this will not work. I feel like it is reasonable to add an API that is exported by Sqlite.jsm to set this property and use that instead.
Comment hidden (mozreview-request)

Comment 3

2 years ago
mozreview-review
Comment on attachment 8881272 [details]
Bug 1371844 - Add explicit API to set Debugging.failTestsOnAutoClose in Sqlite.jsm.

https://reviewboard.mozilla.org/r/152484/#review157744

SGTM, thank you
Attachment #8881272 - Flags: review?(mak77) → review+

Comment 4

2 years ago
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d8fe35fb8366
Add explicit API to set Debugging.failTestsOnAutoClose in Sqlite.jsm. r=mak

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d8fe35fb8366
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.