59 bytes, text/x-review-board-request
test_sqlite.js sets a property on the Debugging object on the global in Sqlite.jsm like this: Cu.getGlobalForObject(Sqlite).Debugging.failTestsOnAutoClose = enabled; With JSM global merging (bug 1186409), the Debugging object will be on a special per-JSM object, not the global, so this will not work. I feel like it is reasonable to add an API that is exported by Sqlite.jsm to set this property and use that instead.
Comment on attachment 8881272 [details] Bug 1371844 - Add explicit API to set Debugging.failTestsOnAutoClose in Sqlite.jsm. https://reviewboard.mozilla.org/r/152484/#review157744 SGTM, thank you
Attachment #8881272 - Flags: review?(mak77) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/d8fe35fb8366 Add explicit API to set Debugging.failTestsOnAutoClose in Sqlite.jsm. r=mak
You need to log in before you can comment on or make changes to this bug.