1371844 - Add explicit API to set Debugging.failTestsOnAutoClose

Status: RESOLVED FIXED

(Core :: SQLite and Embedded Database Bindings, enhancement)

Description

[Andrew McCreight [:mccr8]]

test_sqlite.js sets a property on the Debugging object on the global in Sqlite.jsm like this:
  Cu.getGlobalForObject(Sqlite).Debugging.failTestsOnAutoClose = enabled;

With JSM global merging (bug 1186409), the Debugging object will be on a special per-JSM object, not the global, so this will not work. I feel like it is reasonable to add an API that is exported by Sqlite.jsm to set this property and use that instead.

Comment 1

[Andrew McCreight [:mccr8]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2bc86f7c752b909dda833a828a908f0d9a3d6a3e

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: Bug 1371844 - Add explicit API to set Debugging.failTestsOnAutoClose in Sqlite.jsm.

With JSM global sharing, the Debugging object is no longer a property
directly on the global of the Sqllite object. Instead of going through
this back door, add a setter method to Sqllite and use that.

Review commit: https://reviewboard.mozilla.org/r/152484/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/152484/

Comment 3

[Marco Bonardo [:mak]]

Comment on attachment 8881272 [details]
Bug 1371844 - Add explicit API to set Debugging.failTestsOnAutoClose in Sqlite.jsm.

https://reviewboard.mozilla.org/r/152484/#review157744

SGTM, thank you

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d8fe35fb8366
Add explicit API to set Debugging.failTestsOnAutoClose in Sqlite.jsm. r=mak

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d8fe35fb8366