1371958 - FrameLayerBuilder does unnecessary hashtable lookups

Status: RESOLVED FIXED

(Core :: Web Painting, enhancement, P2)

Comment 1

[Mats Palmgren (inactive)]

Oh, looks like FrameLayerBuilder::ComputeGeometryChangeForItem is also doing unnecessary hashtable lookups...

Comment 2

[Mats Palmgren (inactive)]

Attachment: part 1 - Use EnsureRemoved instead of Contains+RemoveEntry to avoid an unnecessary hashtable lookup

Comment 3

[Mats Palmgren (inactive)]

Attachment: part 2 - Move a mPaintedLayerItems.GetEntry() call into the else-branch where its result is actually used to avoid an unnecessary hashtable lookup when we don't take the else-branch

Comment 4

[Nathan Froyd [:froydnj]]

Comment on attachment 8876445 [details] [diff] [review]
part 2 - Move a mPaintedLayerItems.GetEntry() call into the else-branch where its result is actually used to avoid an unnecessary hashtable lookup when we don't take the else-branch

Review of attachment 8876445 [details] [diff] [review]:
-----------------------------------------------------------------

I *think* the intervening calls between the points that got changed wouldn't add entries to the hashtable such that we change behavior here, but that should really be verifiabled by a module peer.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/888cb6362ed8
part 1 - Use EnsureRemoved instead of Contains+RemoveEntry to avoid an unnecessary hashtable lookup.  r=froydnj
https://hg.mozilla.org/integration/mozilla-inbound/rev/59b1fd575d3d
part 2 - Move a mPaintedLayerItems.GetEntry() call into the else-branch where its result is actually used to avoid an unnecessary hashtable lookup when we don't take the else-branch.  r=froydnj

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/888cb6362ed8
https://hg.mozilla.org/mozilla-central/rev/59b1fd575d3d