Closed Bug 1371961 Opened 2 years ago Closed 2 years ago
Loader::Remove From Cache does unnecessary hashtable lookups
No description provided.
I doubt |aValue| can ever be null when we found an entry to remove, but let's be conservative and do minimal changes here.
Comment on attachment 8876447 [details] [diff] [review] Use LookupRemoveIf instead of Get+Remove to avoid unnecessary hashtable lookups Actually, nsRefPtrHashtable::Remove(KeyType aKey, UserDataType* aData) might be a better choice here...
Attachment #8876448 - Flags: review?(nfroyd) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/2b8c8bc6ba8b Use nsRefPtrHashtable::Remove instead of Get + nsBaseHashtable::Remove to avoid unnecessary hashtable lookups. r=froydnj
You need to log in before you can comment on or make changes to this bug.