1371970 - TestPrintf is not executed on automation

Status: RESOLVED FIXED

(Testing :: Code Coverage, defect)

Description

[Kyle Lahnakoski [:ekyle]]

Please verify that the moxzglue tests are part of a test suite that is part of the scheduled codecoverage run.

Here is some test code

> https://dxr.mozilla.org/mozilla-central/source/mozglue/tests/TestPrintf.cpp?q=mozglue%2Ftests%2FTestPrintf.cpp&redirect_type=direct

Here is the file it should cover

> https://codecov.io/gh/marco-c/gecko-dev/src/master/mozglue/misc/Printf.cpp

Comment 1

[Greg Mierzwinski [:sparky]]

It's coverage is collected in the CPP test suite:  https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=8a990794c2ee923ccd839750912d10ff3a690a2a&filter-searchStr=ccov&selectedJob=106112913

Here's part of the live_backing.log file:
[task 2017-06-10T18:56:23.724103Z] 18:56:23     INFO -  testPrivateGCThingValue
[task 2017-06-10T18:56:23.724321Z] 18:56:23     INFO -  TEST-PASS | testPrivateGCThingValue | ok
[task 2017-06-10T18:56:23.724548Z] 18:56:23     INFO -  testPrintf
[task 2017-06-10T18:56:23.724765Z] 18:56:23     INFO -  TEST-PASS | testPrintf | ok
[task 2017-06-10T18:56:23.724975Z] 18:56:23     INFO -  test_PreserveJitCode
[task 2017-06-10T18:56:23.725188Z] 18:56:23     INFO -  TEST-PASS | test_PreserveJitCode | ok

Comment 2

[Greg Mierzwinski [:sparky]]

Ah, wrong TestPrintf...

Comment 3

[Greg Mierzwinski [:sparky]]

I see that TestPrintf uses CppUnitTests instead of GeckoCppUnitTests here at [1]. And that 'ShowSSEConfig' is running in CPP. 

Another thing I found is that we might be losing the test at [2] because of the lower() function, but I'll have to look into this some more.

[1]: https://dxr.mozilla.org/mozilla-central/source/mozglue/tests/moz.build#9
[2]: https://dxr.mozilla.org/mozilla-central/source/python/mozbuild/mozbuild/util.py#445

Comment 4

[Marco Castelluccio [:marco]]

See bug 1379526 comment 1 and 2.

Comment 6

[Marco Castelluccio [:marco]]

I believe this test is not getting executed in any build, at least I can't see any reference to TestPrintf in the logs of a linux64-debug build: https://treeherder.mozilla.org/logviewer.html#?job_id=113383388&repo=mozilla-central.

I can see ShowSSEConfig, but I can't see TestPrintf (note there is a "testPrintf", but that one is a different test from jsapi-tests).

Comment 7

[Marco Castelluccio [:marco]]

I think we need to add the file to https://dxr.mozilla.org/mozilla-central/source/testing/cppunittest.ini.

Comment 8

[Marco Castelluccio [:marco]]

Attachment: Patch

Comment 9

[Marco Castelluccio [:marco]]

It was executed in this try build: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4152d1f9a604c9cf936b656c15130f2a174c5b96&selectedJob=113474322.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5a2528017eae
Add TestPrintf to cppunittest.ini to make it execute on automation. r=glandium

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5a2528017eae