Closed Bug 1371975 Opened 7 years ago Closed 7 years ago

stylo: The "handled for descendants" optimization is quite broken.

Categories

(Core :: CSS Parsing and Computation, enhancement, P1)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: emilio, Assigned: emilio)

References

(Blocks 1 open bug)

Details

Debugging bug 1371955, logging the change hints we end up posting to the change list, I see a gazillion of RepaintFrame going on.

RepaintFrame is a change hint of those that are "handled for descendants", and we should only push it for the root of the subtree that needs to be repainted, AIUI.

Yet we only use it to avoid reframing NAC that is going to be reframed anyway, not to change what gets stored in restyle_damage...

I'm going to fix this as part of bug 1368236, where I'm also killing a good amount of this complexity.
See Also: → 1371955, 1368240
Assignee: nobody → emilio+bugs
Priority: -- → P1
Fixed in bug 1368236
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.