CustomElementRegistry::WhenDefined does unnecessary hashtable lookups

RESOLVED FIXED in Firefox 56

Status

()

Core
DOM: Core & HTML
P2
normal
RESOLVED FIXED
2 months ago
2 months ago

People

(Reporter: mats, Assigned: mats)

Tracking

({perf})

Trunk
mozilla56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

2 months ago
Created attachment 8876526 [details] [diff] [review]
Use LookupForAdd instead of Contains+Get/Put to avoid an unnecessary hashtable lookup
Attachment #8876526 - Flags: review?(nfroyd)

Updated

2 months ago
Attachment #8876526 - Flags: review?(nfroyd) → review+

Comment 2

2 months ago
Pushed by mpalmgren@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/55feb5bb2523
Use LookupForAdd instead of Contains+Get/Put to avoid an unnecessary hashtable lookup.  r=froydnj
https://hg.mozilla.org/mozilla-central/rev/55feb5bb2523
Status: NEW → RESOLVED
Last Resolved: 2 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.