Closed Bug 1372167 Opened 2 years ago Closed 2 years ago

Unify l10n.ini and filter.py into a single (python-independent) format for comm-central apps

Categories

(Thunderbird :: Build Config, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Pike, Assigned: Pike)

References

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1370176 +++

Mirror the work in bug 1370176 for comm-central. Filing this in Thunderbird, I'm hoping to land the suite changes as part of this bug, too.

For c-c, there are a few interesting changes. Things get a ton easier, as we now have a way to override paths at runtime, and we can map foo/something to something. This has two consequences:

- not everything that we include from m-c needs to have a config file. In particular, this means services/sync can be included just as a directory
- we don't need a config per branch. The configs that reference the in-tree configs will know where to find which version of m-c.

The other change is that the upcoming version of compare-locales also pays attention to the locale list in sub-configs. Aka, once everything is moved over to the new configs, we can drop calendar as an independent module, and just make it something that's enabled as part of Thunderbird, for just some locales.

The documentation for the upcoming configuration is in its own project, as we'll share the configuration logic with all projects at mozilla eventually. Those docs are at http://moz-l10n-config.readthedocs.io/.
Comment on attachment 8876701 [details]
bug 1372167, toml l10n configs for Thunderbird, Calendar, SeaMonkey,

https://reviewboard.mozilla.org/r/148036/#review152816

Looks good to me for Thunderbird/Calendar. You should r? ewong or frg for Seamonkey.
Attachment #8876701 - Flags: review?(philipp) → review+
Attachment #8876701 - Flags: review?(ewong)
Comment on attachment 8876701 [details]
bug 1372167, toml l10n configs for Thunderbird, Calendar, SeaMonkey,

https://reviewboard.mozilla.org/r/148036/#review154984

the suite changes look good, though fwiw, if TOML is a moving target, wouldn't we be setting us up for another round
of changes if and when toml stabilizes?

::: suite/locales/l10n.toml:9
(Diff revision 1)
> +
> +basepath = "../.."
> +
> +locales = [
> +    "ca",
> +    "cs",

Please remove ca and gl.  They are no longer
supported.
Attachment #8876701 - Flags: review?(ewong)
Comment on attachment 8876701 [details]
bug 1372167, toml l10n configs for Thunderbird, Calendar, SeaMonkey,

https://reviewboard.mozilla.org/r/148036/#review154992

::: suite/locales/l10n.toml:8
(Diff revision 1)
> +# file, You can obtain one at http://mozilla.org/MPL/2.0/.
> +
> +basepath = "../.."
> +
> +locales = [
> +    "ca",

Please remove ca.

::: suite/locales/l10n.toml:17
(Diff revision 1)
> +    "en-GB",
> +    "es-AR",
> +    "es-ES",
> +    "fi",
> +    "fr",
> +    "gl",

Please remove gl.
Comment on attachment 8876701 [details]
bug 1372167, toml l10n configs for Thunderbird, Calendar, SeaMonkey,

https://reviewboard.mozilla.org/r/148036/#review154994
Comment on attachment 8876701 [details]
bug 1372167, toml l10n configs for Thunderbird, Calendar, SeaMonkey,

https://reviewboard.mozilla.org/r/148036/#review154984

> Please remove ca and gl.  They are no longer
> supported.

do note: first time reviewing on reviewboard so quite confused as to what's going on.
Comment on attachment 8876701 [details]
bug 1372167, toml l10n configs for Thunderbird, Calendar, SeaMonkey,

https://reviewboard.mozilla.org/r/148036/#review154998
Attachment #8876701 - Flags: review+
Put it in my test tree yesterday. Overall looks good but I still hit bug 1231349 and was unable to build an l10n SeaMonkey successfully. Wasn't unexpexcted because the old compare-locales is still in the mozilla tree.
Landed as https://hg.mozilla.org/comm-central/rev/bd78c240ad996e5b46ba87f4b85ca8dd385a2c39.

Edmund, can we do the locale changes in dedicated bugs? Also, we'll need to change them in a couple of places right now?

There's bug 1218107 for Galician, I haven't found a bug for Catalan?
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.