1372230 - Vendor encoding_rs 0.7.0 into m-c

Status: RESOLVED FIXED

(Core :: Internationalization, enhancement, P3)

Description

[Henri Sivonen (:hsivonen)]

Will boost perf on x86, x86_64 and aarch64.

Comment 1

[Henri Sivonen (:hsivonen)]

Attachment: Bug 1372230 part 1 - Move the code behing mozilla::Encoding::ForName() from encoding_rs to encoding_glue.

Review commit: https://reviewboard.mozilla.org/r/173178/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/173178/

Comment 2

[Henri Sivonen (:hsivonen)]

Attachment: Bug 1372230 part 2 - Update encoding_rs to 0.7.0 and encoding_c to 0.8.0.

Review commit: https://reviewboard.mozilla.org/r/173180/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/173180/

Comment 3

[Henri Sivonen (:hsivonen)]

Key changes:
 * Make "replacement" a label of replacement.
 * Move Rust backing code of Encoding::ForName() from the crates.io crate to m-c.
 * Sync Rust standard-library changes to UTF-8 validation to the encoding_rs's (hopefully temporary) fork of the code.
 * Ensure the fork is only used in configurations where the fork is known to be faster.
 * ASCII handling optimizations generally.
 * Added SIMD support for Aarch64. (Already enabled in the build system but didn't do much previously.)

Comment 4

[Henri Sivonen (:hsivonen)]

Comment on attachment 8901733 [details]
Bug 1372230 part 2 - Update encoding_rs to 0.7.0 and encoding_c to 0.8.0.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/173180/diff/1-2/

Comment 5

[Henri Sivonen (:hsivonen)]

Comment on attachment 8901733 [details]
Bug 1372230 part 2 - Update encoding_rs to 0.7.0 and encoding_c to 0.8.0.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/173180/diff/2-3/

Comment 6

[Masatoshi Kimura [:emk]]

Comment on attachment 8901732 [details]
Bug 1372230 part 1 - Move the code behing mozilla::Encoding::ForName() from encoding_rs to encoding_glue.

https://reviewboard.mozilla.org/r/173178/#review178562

Comment 7

[Masatoshi Kimura [:emk]]

Comment on attachment 8901733 [details]
Bug 1372230 part 2 - Update encoding_rs to 0.7.0 and encoding_c to 0.8.0.

https://reviewboard.mozilla.org/r/173180/#review178564

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e4fe008d0265
part 1 - Move the code behing mozilla::Encoding::ForName() from encoding_rs to encoding_glue. r=emk
https://hg.mozilla.org/integration/autoland/rev/72887ce9eaba
part 2 - Update encoding_rs to 0.7.0 and encoding_c to 0.8.0. r=emk

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e4fe008d0265
https://hg.mozilla.org/mozilla-central/rev/72887ce9eaba