Closed Bug 1372230 Opened 2 years ago Closed 2 years ago

Vendor encoding_rs 0.7.0 into m-c

Categories

(Core :: Internationalization, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: hsivonen, Assigned: hsivonen)

References

Details

Attachments

(2 files)

Will boost perf on x86, x86_64 and aarch64.
Priority: -- → P3
Blocks: 1385836
Assignee: nobody → hsivonen
Status: NEW → ASSIGNED
Summary: Vendor encoding_rs 0.6.12 into m-c → Vendor encoding_rs 0.7.0 into m-c
Key changes:
 * Make "replacement" a label of replacement.
 * Move Rust backing code of Encoding::ForName() from the crates.io crate to m-c.
 * Sync Rust standard-library changes to UTF-8 validation to the encoding_rs's (hopefully temporary) fork of the code.
 * Ensure the fork is only used in configurations where the fork is known to be faster.
 * ASCII handling optimizations generally.
 * Added SIMD support for Aarch64. (Already enabled in the build system but didn't do much previously.)
Attachment #8901732 - Flags: review?(VYV03354)
Attachment #8901733 - Flags: review?(VYV03354)
Comment on attachment 8901732 [details]
Bug 1372230 part 1 - Move the code behing mozilla::Encoding::ForName() from encoding_rs to encoding_glue.

https://reviewboard.mozilla.org/r/173178/#review178562
Attachment #8901732 - Flags: review?(VYV03354) → review+
Comment on attachment 8901733 [details]
Bug 1372230 part 2 - Update encoding_rs to 0.7.0 and encoding_c to 0.8.0.

https://reviewboard.mozilla.org/r/173180/#review178564
Attachment #8901733 - Flags: review?(VYV03354) → review+
Pushed by hsivonen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e4fe008d0265
part 1 - Move the code behing mozilla::Encoding::ForName() from encoding_rs to encoding_glue. r=emk
https://hg.mozilla.org/integration/autoland/rev/72887ce9eaba
part 2 - Update encoding_rs to 0.7.0 and encoding_c to 0.8.0. r=emk
https://hg.mozilla.org/mozilla-central/rev/e4fe008d0265
https://hg.mozilla.org/mozilla-central/rev/72887ce9eaba
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.