1372251 - [compare-locales] Add command-line argument to overwrite configuration env entries

Status: RESOLVED FIXED

(Localization Infrastructure and Tools :: compare-locales, enhancement)

Description

[Axel Hecht [:Pike]]

For c-c, we have the path to mozilla-central encoded in the config as an env variable.

To pick up source-tree configs, and to digest this for automation, we need to be able to overwrite this, in particular also via the commandline.

Comment 1

[Axel Hecht [:Pike]]

Attachment: bug 1372251, add commandline argument to overwrite variables in toml files,

Mostly useful to determine where on a commandline to find included
repositories. I.e., you can do

  compare-locales -Dmozilla=../mozilla-central mail/locales/l10n.toml /src/central/l10n-central/ fr

and get compare-locales output without having m-c in c-c/mozilla.

Review commit: https://reviewboard.mozilla.org/r/157350/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/157350/

Comment 2

[Staś Małolepszy :stas]

Comment on attachment 8886536 [details]
bug 1372251, add commandline argument to overwrite variables in toml files,

https://reviewboard.mozilla.org/r/157350/#review162532

::: compare_locales/commands.py:141
(Diff revision 1)
> +        for define in args.D:
> +            define_tuple = define.split('=', 1)
> +            if len(define_tuple) == 1:
> +                # no '=' in define, assume empty string
> +                define_tuple.append('')
> +            config_env[define_tuple[0]] = define_tuple[1]

This can be written more concisely with `partition`, which splits only once and uses empty strings as fallback:

    key, _, value = define.partition('=')
    config_env[key] = value

Comment 3

[Axel Hecht [:Pike]]

Comment on attachment 8886536 [details]
bug 1372251, add commandline argument to overwrite variables in toml files,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157350/diff/1-2/

Comment 4

[Axel Hecht [:Pike]]

https://hg.mozilla.org/l10n/compare-locales/rev/208a84e6adaee84e2f2a80b044409fa5f8924f0b, marking fixed.

Thanks.