1372252 - Permafailing Beta 55 ts_paint_webext | AddonInstallException: ERROR_SIGNEDSTATE_REQUIRED: The addon must be signed and isn't

Status: RESOLVED FIXED

(Testing :: Talos, enhancement)

Description

[Ryan VanderMeulen [:RyanVM]]

Looks like we just need to sign the addon.
https://treeherder.mozilla.org/logviewer.html#?job_id=106360746&repo=mozilla-beta

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

I assume we can use the same jpm toolchain we use for legacy stuff:
https://wiki.mozilla.org/EngineeringProductivity/HowTo/SignExtensions#Signing_an_Addon

:andym- can you confirm the procedure for signing webextensions vs addons?

Comment 2

[Andrew Swan [:aswan]]

Signing the webextension would be an expedient fix but once bug 1361002 is fixed you shouldn't need to.
If you want to do signing in the short term:
https://mana.mozilla.org/wiki/display/ateam/Signing+Extensions+in+Tree

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f232a1b8e873

Comment 4

[Ryan VanderMeulen [:RyanVM]]

This is still happening with bug 1361002 landed on Beta.
https://treeherder.mozilla.org/logviewer.html#?job_id=106496863&repo=mozilla-beta

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

is bug 1370328 on beta?  it should be as we have landed it a week ago prior to the big merge.  :ryanvm, if you could check that would help

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Yup.
https://hg.mozilla.org/releases/mozilla-beta/rev/f2737791ec8e

Comment 7

[Julien Cristau [:jcristau]]

tracking this test failure for 55

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

testing a signed extension on try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2d9e74af32f63ef67bb7fba50b193d59bb37b9f7

and forcing the addons to be signed on try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=120218879d4662944eab113cbe25bc37fb987336

Comment 9

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: sign the dummy webextension

try runs look good, lets just land this!

Comment 10

[Robert Wood [:rwood]]

Comment on attachment 8877703 [details] [diff] [review]
sign the dummy webextension

Review of attachment 8877703 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/930950ef5998
Sign the dummy webextension used in ts_paint_webext so that it doesn't run afoul of addon signing restrictions on Beta. r=rwood

Comment 12

[Ryan VanderMeulen [:RyanVM]]

WTF, I uplifted this to Beta and it's *still* failing!
https://treeherder.mozilla.org/logviewer.html#?job_id=107207825&repo=mozilla-beta

https://hg.mozilla.org/releases/mozilla-beta/rev/f5b4c1e362ec5c88ff5b08535c8277278c6a6713

Comment 13

[Joel Maher ( :jmaher ) (UTC -8)]

:aswan, can you help out here, I am at a loss of what to do.

Comment 14

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/930950ef5998

Comment 15

[Andrew Swan [:aswan]]

The extension itself looks good to me.  I'm unable to load anything from treeherder right now, is it still failing with the same error (SIGNEDSTATE_REQUIRED)?

Comment 16

[Joel Maher ( :jmaher ) (UTC -8)]

yes, same error- from a recent log:
https://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-beta-macosx64/mozilla-beta_yosemite_r7_test-g5-e10s-bm108-tests1-macosx-build3.txt.gz

08:13:49     INFO -  TEST-UNEXPECTED-ERROR | tp5o_webext | AddonInstallException: ERROR_SIGNEDSTATE_REQUIRED: The addon must be signed and isn't.
08:13:49    ERROR -  Traceback (most recent call last):
08:13:49     INFO -    File "/builds/slave/test/build/tests/talos/talos/run_tests.py", line 235, in run_tests
08:13:49     INFO -      talos_results.add(mytest.runTest(browser_config, test))
08:13:49     INFO -    File "/builds/slave/test/build/tests/talos/talos/ttest.py", line 69, in runTest
08:13:49     INFO -      with FFSetup(browser_config, test_config) as setup:
08:13:49     INFO -    File "/builds/slave/test/build/tests/talos/talos/ffsetup.py", line 204, in __enter__
08:13:49     INFO -      self._run_profile()
08:13:49     INFO -    File "/builds/slave/test/build/tests/talos/talos/ffsetup.py", line 151, in _run_profile
08:13:49     INFO -      addons.install(filename)
08:13:49     INFO -    File "/builds/slave/test/build/venv/lib/python2.7/site-packages/marionette_driver/addons.py", line 93, in install
08:13:49     INFO -      raise AddonInstallException(ADDON_INSTALL_ERRORS[status])
08:13:49     INFO -  AddonInstallException: AddonInstallException: ERROR_SIGNEDSTATE_REQUIRED: The addon must be signed and isn't.


this doesn't fail on windows/opt builds, only on windows pgo.  osxdevedition passes, but addon signing is disabled there.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

Note that "window opt" are mislabeled DevEdition tests as well (which at least makes the results saner to comprehend)

Comment 18

[Andrew Swan [:aswan]]

Is the problem as simple as ts_paint_webext got updated but tp5o_webext did not:
https://hg.mozilla.org/releases/mozilla-beta/file/9e20e9175de1/testing/talos/talos/test.py#l526

Comment 19

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: add signed extension for tp5o_webext

I cannot believe I overlooked this, but glad to have it pointed out.  I am not confident this will help, but I want to at least get this landed and in place so we have less concerns in the future.

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/25fef8caf5cd
Permafailing Beta 55 ts_paint_webext- add signed extension for all webext tests. r=rwood

Comment 21

[Andrew Swan [:aswan]]

I guess we'll see what happens but why don't you think this will help?  Note that the subject of the bug references "ts_paint_webext" and the error in comment 16 which happened after the original patch was pushed doesn't mention ts_paint but it does mention "tp5o_webext".

Comment 22

[Joel Maher ( :jmaher ) (UTC -8)]

oh, I missed that- maybe we are good- lets see.

:RyanVM- can you uplift this to beta.

Comment 23

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/dbcc401cf103

Green at last!

Comment 24

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/25fef8caf5cd