Closed Bug 1372252 Opened 2 years ago Closed 2 years ago

Permafailing Beta 55 ts_paint_webext | AddonInstallException: ERROR_SIGNEDSTATE_REQUIRED: The addon must be signed and isn't

Categories

(Testing :: Talos, enhancement)

enhancement
Not set

Tracking

(firefox-esr52 unaffected, firefox53 unaffected, firefox54 unaffected, firefox55+ fixed, firefox56 fixed)

RESOLVED FIXED
mozilla56
Tracking Status
firefox-esr52 --- unaffected
firefox53 --- unaffected
firefox54 --- unaffected
firefox55 + fixed
firefox56 --- fixed

People

(Reporter: RyanVM, Assigned: jmaher)

References

Details

(Whiteboard: [PI:June])

Attachments

(2 files)

Looks like we just need to sign the addon.
https://treeherder.mozilla.org/logviewer.html#?job_id=106360746&repo=mozilla-beta
Flags: needinfo?(jmaher)
I assume we can use the same jpm toolchain we use for legacy stuff:
https://wiki.mozilla.org/EngineeringProductivity/HowTo/SignExtensions#Signing_an_Addon

:andym- can you confirm the procedure for signing webextensions vs addons?
Flags: needinfo?(jmaher) → needinfo?(amckay)
Whiteboard: [PI:June]
Signing the webextension would be an expedient fix but once bug 1361002 is fixed you shouldn't need to.
If you want to do signing in the short term:
https://mana.mozilla.org/wiki/display/ateam/Signing+Extensions+in+Tree
Flags: needinfo?(amckay)
Depends on: 1361002
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
This is still happening with bug 1361002 landed on Beta.
https://treeherder.mozilla.org/logviewer.html#?job_id=106496863&repo=mozilla-beta
Status: RESOLVED → REOPENED
Flags: needinfo?(jmaher)
Resolution: FIXED → ---
is bug 1370328 on beta?  it should be as we have landed it a week ago prior to the big merge.  :ryanvm, if you could check that would help
Flags: needinfo?(jmaher) → needinfo?(ryanvm)
tracking this test failure for 55
try runs look good, lets just land this!
Attachment #8877703 - Flags: review?(rwood)
Comment on attachment 8877703 [details] [diff] [review]
sign the dummy webextension

Review of attachment 8877703 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8877703 - Flags: review?(rwood) → review+
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/930950ef5998
Sign the dummy webextension used in ts_paint_webext so that it doesn't run afoul of addon signing restrictions on Beta. r=rwood
:aswan, can you help out here, I am at a loss of what to do.
Flags: needinfo?(aswan)
The extension itself looks good to me.  I'm unable to load anything from treeherder right now, is it still failing with the same error (SIGNEDSTATE_REQUIRED)?
Flags: needinfo?(aswan)
yes, same error- from a recent log:
https://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-beta-macosx64/mozilla-beta_yosemite_r7_test-g5-e10s-bm108-tests1-macosx-build3.txt.gz

08:13:49     INFO -  TEST-UNEXPECTED-ERROR | tp5o_webext | AddonInstallException: ERROR_SIGNEDSTATE_REQUIRED: The addon must be signed and isn't.
08:13:49    ERROR -  Traceback (most recent call last):
08:13:49     INFO -    File "/builds/slave/test/build/tests/talos/talos/run_tests.py", line 235, in run_tests
08:13:49     INFO -      talos_results.add(mytest.runTest(browser_config, test))
08:13:49     INFO -    File "/builds/slave/test/build/tests/talos/talos/ttest.py", line 69, in runTest
08:13:49     INFO -      with FFSetup(browser_config, test_config) as setup:
08:13:49     INFO -    File "/builds/slave/test/build/tests/talos/talos/ffsetup.py", line 204, in __enter__
08:13:49     INFO -      self._run_profile()
08:13:49     INFO -    File "/builds/slave/test/build/tests/talos/talos/ffsetup.py", line 151, in _run_profile
08:13:49     INFO -      addons.install(filename)
08:13:49     INFO -    File "/builds/slave/test/build/venv/lib/python2.7/site-packages/marionette_driver/addons.py", line 93, in install
08:13:49     INFO -      raise AddonInstallException(ADDON_INSTALL_ERRORS[status])
08:13:49     INFO -  AddonInstallException: AddonInstallException: ERROR_SIGNEDSTATE_REQUIRED: The addon must be signed and isn't.


this doesn't fail on windows/opt builds, only on windows pgo.  osxdevedition passes, but addon signing is disabled there.
Note that "window opt" are mislabeled DevEdition tests as well (which at least makes the results saner to comprehend)
Is the problem as simple as ts_paint_webext got updated but tp5o_webext did not:
https://hg.mozilla.org/releases/mozilla-beta/file/9e20e9175de1/testing/talos/talos/test.py#l526
Flags: needinfo?(jmaher)
I cannot believe I overlooked this, but glad to have it pointed out.  I am not confident this will help, but I want to at least get this landed and in place so we have less concerns in the future.
Flags: needinfo?(jmaher)
Attachment #8878099 - Flags: review?(rwood)
Attachment #8878099 - Flags: review?(rwood) → review+
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/25fef8caf5cd
Permafailing Beta 55 ts_paint_webext- add signed extension for all webext tests. r=rwood
I guess we'll see what happens but why don't you think this will help?  Note that the subject of the bug references "ts_paint_webext" and the error in comment 16 which happened after the original patch was pushed doesn't mention ts_paint but it does mention "tp5o_webext".
oh, I missed that- maybe we are good- lets see.

:RyanVM- can you uplift this to beta.
Flags: needinfo?(ryanvm)
https://hg.mozilla.org/mozilla-central/rev/25fef8caf5cd
Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.