1372262 - nsGlobalWindow::GetGroupMessageManager does unnecessary hashtable lookups

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P2)

Comment 1

[Mats Palmgren (inactive)]

Attachment: Use LookupForAdd instead of Get+Put to avoid unnecessary hashtable lookups

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8876770 [details] [diff] [review]
Use LookupForAdd instead of Get+Put to avoid unnecessary hashtable lookups

Review of attachment 8876770 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsGlobalWindow.cpp
@@ +14486,5 @@
>    MOZ_ASSERT(IsChromeWindow());
>    MOZ_RELEASE_ASSERT(IsInnerWindow());
>  
>    nsGlobalChromeWindow* myself = static_cast<nsGlobalChromeWindow*>(this);
>    nsCOMPtr<nsIMessageBroadcaster> messageManager =

Would be nice if we passed this ref out of the function rather than returning a raw pointer, too.  Followup bug?

Comment 3

[Mats Palmgren (inactive)]

(In reply to Nathan Froyd [:froydnj] from comment #2)
> Would be nice if we passed this ref out of the function rather than
> returning a raw pointer, too.  Followup bug?

Filed bug 1372764.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a0434f8d2cf1
Use LookupForAdd instead of Get+Put to avoid unnecessary hashtable lookups.  r=froydnj

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/a0434f8d2cf1