1372303 - ssh-ing in to hg.mozilla.org should print your commit access level.

Status: RESOLVED FIXED

(Developer Services :: Mercurial: hg.mozilla.org, enhancement)

Description

[Blake Winton (:bwinton) (:☕️)]

It currently kinda does, but not explicitly.  It would also be good if it could tell whether you had level 1 access, too.  And maybe a message on how to get started if the account doesn't exist (or has level 0 access)?

Comment 1

[Gregory Szorc [:gps]]

Printing the group memberships would be a clear user experience win. Configuring SSH access is a PITA to begin with. So if we can write the docs to say `ssh hg.mozilla.org` and verify the server doesn't complain, that could help save a lot of troubleshooting.

Comment 2

[Gregory Szorc [:gps]]

Attachment: hgserver: print LDAP group membership for no-op login (bug 1372303);

This seems like a useful thing to have to help users self-debug
permissions failures.

Review commit: https://reviewboard.mozilla.org/r/148200/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/148200/

Comment 3

[:glob ✱]

Comment on attachment 8876870 [details]
hgserver: print LDAP group membership for no-op login (bug 1372303);

https://reviewboard.mozilla.org/r/148200/#review152696

::: hgserver/pash/hg_helper.py:68
(Diff revision 1)
> +You are NOT a member of any LDAP groups that govern source control
> +access. You will NOT be able to push to any repo until group membership
> +is added.

given the target audience, i think the wording of this response shouldn't refer to the implementation details, and should contain a pointer to how one should request the required level of access.

how about:

You are NOT a member of any LDAP groups that govern source control access.

You will NOT be able to push to any repository until you have been granted commit access.

See https://www.mozilla.org/about/governance/policies/commit/access-policy/ for more information.

Comment 4

[Kendall Libby [:fubar] (he/him)]

Comment on attachment 8876870 [details]
hgserver: print LDAP group membership for no-op login (bug 1372303);

https://reviewboard.mozilla.org/r/148200/#review152918

lgtm; ++ to glob's suggestion

Comment 5

[Gregory Szorc [:gps]]

Comment on attachment 8876870 [details]
hgserver: print LDAP group membership for no-op login (bug 1372303);

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/148200/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/e29d0b981e91
hgserver: print LDAP group membership for no-op login ; r=fubar