browser tests data urls are unescaped

RESOLVED FIXED in Firefox 56

Status

()

Core
Disability Access APIs
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: eeejay, Assigned: eeejay)

Tracking

unspecified
mozilla56
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
This causes issues with:
1. Unicode characters in the test snippets.
2. "#" is interpreted as a fragment identifier and everything past it is removed.

This manifests in a test here:
https://dxr.mozilla.org/mozilla-central/source/accessible/tests/browser/e10s/browser_caching_name.js#242

The third expected result is wrong, it should be the value of the subtree ("This is a paragraph This is a link • Listitem1 • Listitem2"), but instead is just "This is a paragraph".

This is because there is an anchor tag there with href="#".
(Assignee)

Updated

a year ago
Assignee: nobody → eitan
Blocks: 1369890
(Assignee)

Comment 1

a year ago
Created attachment 8876844 [details] [diff] [review]
Encode data URIs to base64 in accessibility browser tests. r?surkov
Attachment #8876844 - Flags: review?(surkov.alexander)

Comment 2

a year ago
Comment on attachment 8876844 [details] [diff] [review]
Encode data URIs to base64 in accessibility browser tests. r?surkov

Review of attachment 8876844 [details] [diff] [review]:
-----------------------------------------------------------------

good catch
Attachment #8876844 - Flags: review?(surkov.alexander) → review+

Comment 3

a year ago
Pushed by eisaacson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1017f3b4d34e
Encode data URIs to base64 in accessibility browser tests. r=surkov

Comment 4

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1017f3b4d34e
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox56: --- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.