Closed Bug 1372315 Opened 7 years ago Closed 7 years ago

browser tests data urls are unescaped

Categories

(Core :: Disability Access APIs, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: eeejay, Assigned: eeejay)

References

Details

Attachments

(1 file)

This causes issues with:
1. Unicode characters in the test snippets.
2. "#" is interpreted as a fragment identifier and everything past it is removed.

This manifests in a test here:
https://dxr.mozilla.org/mozilla-central/source/accessible/tests/browser/e10s/browser_caching_name.js#242

The third expected result is wrong, it should be the value of the subtree ("This is a paragraph This is a link • Listitem1 • Listitem2"), but instead is just "This is a paragraph".

This is because there is an anchor tag there with href="#".
Assignee: nobody → eitan
Blocks: 1369890
Comment on attachment 8876844 [details] [diff] [review]
Encode data URIs to base64 in accessibility browser tests. r?surkov

Review of attachment 8876844 [details] [diff] [review]:
-----------------------------------------------------------------

good catch
Attachment #8876844 - Flags: review?(surkov.alexander) → review+
Pushed by eisaacson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1017f3b4d34e
Encode data URIs to base64 in accessibility browser tests. r=surkov
https://hg.mozilla.org/mozilla-central/rev/1017f3b4d34e
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: