1372323 - Console::IncreaseCounter does unnecessary hashtable lookups

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P2)

Comment 1

[Mats Palmgren (inactive)]

Attachment: Use LookupForAdd instead of Get+Put to avoid unnecessary hashtable lookups

(This is another example where having a Remove method on EntryPtr
would save us a lookup.  I think using LookupForAdd in these cases
is still preferable to Get+Put since the Remove is very rare.)

Comment 2

[Mats Palmgren (inactive)]

(Filed bug 1372333 about adding a Remove() method.)

Comment 3

[Nathan Froyd [:froydnj]]

Comment on attachment 8876860 [details] [diff] [review]
Use LookupForAdd instead of Get+Put to avoid unnecessary hashtable lookups

Review of attachment 8876860 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/console/Console.cpp
@@ +2195,5 @@
>  
>    aCountLabel = string;
>  
> +  const bool maxCountersReached = mCounterRegistry.Count() >= MAX_PAGE_COUNTERS;
> +  auto entry = mCounterRegistry.LookupForAdd(aCountLabel);

Ew.  I think this could be avoided by making EntryPtr a little more powerful, even beyond adding a Remove() method.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/eb36d574ec6e
Use LookupForAdd instead of Get+Put to avoid unnecessary hashtable lookups.  r=froydnj

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/eb36d574ec6e