1372356 - RuntimeService::RegisterWorker/UnregisterWorker does unnecessary hashtable lookups

Status: RESOLVED FIXED

(Core :: DOM: Workers, enhancement, P2)

Comment 1

[Mats Palmgren (inactive)]

Attachment: Use LookupForAdd instead of Get+Put to avoid unnecessary hashtable lookups

Comment 2

[Mats Palmgren (inactive)]

Attachment: Use mWindowMap.LookupForAdd instead of Get+Put, and LookupRemoveIf instead of Get+Remove, to avoid unnecessary hashtable lookups

Comment 3

[Nathan Froyd [:froydnj]]

Comment on attachment 8876886 [details] [diff] [review]
Use mWindowMap.LookupForAdd instead of Get+Put, and LookupRemoveIf instead of Get+Remove, to avoid unnecessary hashtable lookups

Review of attachment 8876886 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/workers/RuntimeService.cpp
@@ +1879,5 @@
> +    DebugOnly<bool> found = false;
> +    mWindowMap.LookupRemoveIf(window,
> +      [&aWorkerPrivate, &found] (nsTArray<WorkerPrivate*>* aWindowArray) {
> +        MOZ_ALWAYS_TRUE(aWindowArray->RemoveElement(aWorkerPrivate));
> +        found = true;

We are using this |found| pattern quite often with this function, maybe we should find some way of integrating it into the function itself?

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3ad2c67c6669
Use LookupForAdd instead of Get+Put to avoid unnecessary hashtable lookups.  r=froydnj
https://hg.mozilla.org/integration/mozilla-inbound/rev/dfd1cb941248
part 2 - Use mWindowMap.LookupForAdd instead of Get+Put, and LookupRemoveIf instead of Get+Remove, to avoid unnecessary hashtable lookups.  r=froydnj

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/3ad2c67c6669
https://hg.mozilla.org/mozilla-central/rev/dfd1cb941248