Closed
Bug 1372385
Opened 7 years ago
Closed 7 years ago
Fix premultiplication for LUMINANCE / LUMINANCE_ALPHA on WebGL2 conformance test
Categories
(Core :: Graphics: CanvasWebGL, enhancement, P1)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: svargas, Assigned: svargas)
References
Details
(Whiteboard: gfx-noted)
Attachments
(2 files, 1 obsolete file)
|
7.43 KB,
patch
|
jgilbert
:
review+
|
Details | Diff | Splinter Review |
|
1.83 KB,
patch
|
jgilbert
:
review+
|
Details | Diff | Splinter Review |
Right now the following test fails because the internal representation of a luminance alpha texture in WebGL 2 is 'RG8', causing the premultiplication to assume the alpha channel is always opaque and refusing to do the multiplication. https://www.khronos.org/registry/webgl/sdk/tests/conformance/textures/misc/tex-image-with-format-and-type.html?webglVersion=2
|
Assignee | |
Comment 1•7 years ago
|
||
Assignee: nobody → svargas
Attachment #8876903 -
Flags: review?(jgilbert)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8876903 [details] [diff] [review] 0001-Bug-1372385-Fix-premultiplication-for-LUMINANCE-LUMI.patch Review of attachment 8876903 [details] [diff] [review]: ----------------------------------------------------------------- Please send this through try!
Attachment #8876903 -
Flags: review?(jgilbert) → review+
|
|
Assignee | |
Comment 3•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6a47d0998e58755213dc560d60cb29b1e2a96e8c
|
|
Assignee | |
Comment 4•7 years ago
|
||
Added cases for SRGB / SRGB_Alpha in FormatForPackingInfo to prevent ext_SRGB.html conformance test failure: https://treeherder.mozilla.org/#/jobs?repo=try&revision=961389ba44cb5dfebd3097fbb86ce58a272740cd
Attachment #8876903 -
Attachment is obsolete: true
Attachment #8878236 -
Flags: review?(jgilbert)
|
|
Assignee | |
Comment 5•7 years ago
|
||
Forgot to specify mochitest-gl in TryChooser: https://treeherder.mozilla.org/#/jobs?repo=try&revision=077e3f5f1f6d50a30d42211973e7298e8eee4a58
|
|
||
Updated•7 years ago
|
Attachment #8878236 -
Flags: review?(jgilbert) → review+
Pushed by jgilbert@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/91f89d105e2f Fix premultiplication for LUMINANCE / LUMINANCE_ALPHA on WebGL2 conformance test - r=jgilbert
|
||
Comment 7•7 years ago
|
||
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/1fd20434759f528282da8fe419b99b9eba40b170 for unexpected passes of test_2_conformance__textures__misc__tex-image-with-format-and-type.html on OS X, e.g. https://treeherder.mozilla.org/logviewer.html#?job_id=109456159&repo=mozilla-inbound
|
|
Assignee | |
Comment 8•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ab8488c211d8dd394cf685190a683a6951013c26 Updated errata and pushed to try again.
Attachment #8880987 -
Flags: review?(jgilbert)
|
|
||
Updated•7 years ago
|
Attachment #8880987 -
Flags: review?(jgilbert) → review+
|
|
||
Updated•7 years ago
|
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/dfaf0262cbea Fix premultiplication for LUMINANCE / LUMINANCE_ALPHA on WebGL2 conformance test. r=jgilbert https://hg.mozilla.org/integration/mozilla-inbound/rev/5488de6478a5 Remove unexpected OSX mochitest pass from errata. r=jgilbert
Keywords: checkin-needed
|
||
Comment 10•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/dfaf0262cbea https://hg.mozilla.org/mozilla-central/rev/5488de6478a5
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•