Closed Bug 1372385 Opened 3 years ago Closed 2 years ago

Fix premultiplication for LUMINANCE / LUMINANCE_ALPHA on WebGL2 conformance test

Categories

(Core :: Canvas: WebGL, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: svargas, Assigned: svargas)

References

Details

(Whiteboard: gfx-noted)

Attachments

(2 files, 1 obsolete file)

Right now the following test fails because the internal representation of a luminance alpha texture in WebGL 2 is 'RG8', causing the premultiplication to assume the alpha channel is always opaque and refusing to do the multiplication. 

https://www.khronos.org/registry/webgl/sdk/tests/conformance/textures/misc/tex-image-with-format-and-type.html?webglVersion=2
Assignee: nobody → svargas
Attachment #8876903 - Flags: review?(jgilbert)
Comment on attachment 8876903 [details] [diff] [review]
0001-Bug-1372385-Fix-premultiplication-for-LUMINANCE-LUMI.patch

Review of attachment 8876903 [details] [diff] [review]:
-----------------------------------------------------------------

Please send this through try!
Attachment #8876903 - Flags: review?(jgilbert) → review+
Added cases for SRGB / SRGB_Alpha in FormatForPackingInfo to prevent ext_SRGB.html conformance test failure:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=961389ba44cb5dfebd3097fbb86ce58a272740cd
Attachment #8876903 - Attachment is obsolete: true
Attachment #8878236 - Flags: review?(jgilbert)
Attachment #8878236 - Flags: review?(jgilbert) → review+
Pushed by jgilbert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/91f89d105e2f
Fix premultiplication for LUMINANCE / LUMINANCE_ALPHA on WebGL2 conformance test - r=jgilbert
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/1fd20434759f528282da8fe419b99b9eba40b170 for unexpected passes of test_2_conformance__textures__misc__tex-image-with-format-and-type.html on OS X, e.g. https://treeherder.mozilla.org/logviewer.html#?job_id=109456159&repo=mozilla-inbound
Blocks: 1328357
Attachment #8880987 - Flags: review?(jgilbert) → review+
Keywords: checkin-needed
Priority: -- → P1
Whiteboard: gfx-noted
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dfaf0262cbea
Fix premultiplication for LUMINANCE / LUMINANCE_ALPHA on WebGL2 conformance test. r=jgilbert
https://hg.mozilla.org/integration/mozilla-inbound/rev/5488de6478a5
Remove unexpected OSX mochitest pass from errata. r=jgilbert
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/dfaf0262cbea
https://hg.mozilla.org/mozilla-central/rev/5488de6478a5
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.