Closed Bug 1372393 Opened 7 years ago Closed 7 years ago

Update nightly to opus 1.2-rc1

Tracking

()

Status:

RESOLVED FIXED

Milestone:

mozilla56

Tracking Flags:

Tracking

Status

firefox56

---

fixed

People

(Reporter: rillian, Assigned: rillian)

References

Details

Attachments

(4 files)

Bug 1372393 - opus: Fix unified build. 7 years ago Ralph Giles (:rillian) 59 bytes, text/x-review-board-request	kinetik : review+	Details
Bug 1372393 - opus: Update to 1.2-rc1. 7 years ago Ralph Giles (:rillian) 59 bytes, text/x-review-board-request	kinetik : review+	Details
Bug 1372393 - opus: Fix nonunified build patch. 7 years ago Ralph Giles (:rillian) 59 bytes, text/x-review-board-request	kinetik : review+	Details
Bug 1372393 - opus: Fix update script. 7 years ago Ralph Giles (:rillian) 59 bytes, text/x-review-board-request	kinetik : review+	Details

Ralph Giles (:rillian)

Assignee

Description

•

7 years ago

There's a new release candidate for the Opus audio codec reference implementation. Upgrade our in-tree version to help test it while Firefox 56 is on the Nightly channel.

We'll either upgrade to a final release or revert to 1.1.5 before moving to Firefox beta, depending how the testing goes.

Ralph Giles (:rillian)

Assignee

Updated

•

7 years ago

Assignee: nobody → giles

Comment hidden (mozreview-request)

This is no longer necessary thanks to upstream changes.

Review commit: https://reviewboard.mozilla.org/r/148230/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/148230/

Comment hidden (mozreview-request)

Update our in-tree implementation of the opus audio codec
to the 1.2 release candidiate. This gives us some wider
testing before making the first stable release of the
new series.

This release improves the quality and compactness of encoded
audio, and optimizes performance on ARM NEON platforms.

Review commit: https://reviewboard.mozilla.org/r/148232/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/148232/

Comment hidden (mozreview-request)

Comment on attachment 8876906 [details]
Bug 1372393 - opus: Fix unified build.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/148230/diff/1-2/

Comment hidden (mozreview-request)

Comment on attachment 8876907 [details]
Bug 1372393 - opus: Update to 1.2-rc1.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/148232/diff/1-2/

Comment hidden (mozreview-request)

The API of the libopus audio voice/music audio signal classifier
has changed slightly between 1.1.5 and 1.2. Pass in the sample
rate we are using, and the expected application profile.

Review commit: https://reviewboard.mozilla.org/r/148272/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/148272/

Comment hidden (mozreview-request)

Comment on attachment 8876906 [details]
Bug 1372393 - opus: Fix unified build.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/148230/diff/2-3/

Comment hidden (mozreview-request)

Comment on attachment 8876907 [details]
Bug 1372393 - opus: Update to 1.2-rc1.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/148232/diff/2-3/

Ralph Giles (:rillian)

Assignee

Updated

•

7 years ago

Depends on: 1372622

Comment hidden (mozreview-request)

Comment on attachment 8876907 [details]
Bug 1372393 - opus: Update to 1.2-rc1.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/148232/diff/3-4/

Comment hidden (mozreview-request)

Comment on attachment 8876906 [details]
Bug 1372393 - opus: Fix unified build.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/148230/diff/3-4/

Comment hidden (mozreview-request)

Comment on attachment 8876952 [details]
Bug 1372393 - opus: Fix nonunified build patch.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/148272/diff/1-2/

Ralph Giles (:rillian)

Assignee

Updated

•

7 years ago

Depends on: 1372751

Ralph Giles (:rillian)

Assignee

Updated

•

7 years ago

Blocks: 1372767

Comment hidden (mozreview-request)

Handle numbers for SIMD extension versions and variant
spacing in the source file listings.

Review commit: https://reviewboard.mozilla.org/r/149202/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/149202/

Comment hidden (mozreview-request)

Comment on attachment 8876952 [details]
Bug 1372393 - opus: Fix nonunified build patch.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/148272/diff/2-3/

Comment hidden (mozreview-request)

Comment on attachment 8876907 [details]
Bug 1372393 - opus: Update to 1.2-rc1.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/148232/diff/4-5/

Comment hidden (mozreview-request)

Comment on attachment 8876906 [details]
Bug 1372393 - opus: Fix unified build.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/148230/diff/4-5/

Matthew Gregan [:kinetik]

Comment 15

•

7 years ago

mozreview-review

Comment on attachment 8876906 [details]
Bug 1372393 - opus: Fix unified build.

https://reviewboard.mozilla.org/r/148230/#review153690

Attachment #8876906 - Flags: review?(kinetik) → review+

Matthew Gregan [:kinetik]

Comment 16

•

7 years ago

mozreview-review

Comment on attachment 8877769 [details]
Bug 1372393 - opus: Fix update script.

https://reviewboard.mozilla.org/r/149202/#review153692

Attachment #8877769 - Flags: review?(kinetik) → review+

Matthew Gregan [:kinetik]

Comment 17

•

7 years ago

mozreview-review

Comment on attachment 8876952 [details]
Bug 1372393 - opus: Fix nonunified build patch.

https://reviewboard.mozilla.org/r/148272/#review153694

Attachment #8876952 - Flags: review?(kinetik) → review+

Matthew Gregan [:kinetik]

Comment 18

•

7 years ago

mozreview-review

Comment on attachment 8876907 [details]
Bug 1372393 - opus: Update to 1.2-rc1.

https://reviewboard.mozilla.org/r/148232/#review153696

Attachment #8876907 - Flags: review?(kinetik) → review+

Comment hidden (mozreview-request)

Comment on attachment 8877769 [details]
Bug 1372393 - opus: Fix update script.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/149202/diff/1-2/

Comment hidden (mozreview-request)

Comment on attachment 8876952 [details]
Bug 1372393 - opus: Fix nonunified build patch.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/148272/diff/3-4/

Comment hidden (mozreview-request)

Comment on attachment 8876907 [details]
Bug 1372393 - opus: Update to 1.2-rc1.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/148232/diff/5-6/

Comment hidden (mozreview-request)

Comment on attachment 8876906 [details]
Bug 1372393 - opus: Fix unified build.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/148230/diff/5-6/

Pulsebot

Comment 23

•

7 years ago

Pushed by rgiles@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6d7d54dc18b7
opus: Fix update script. r=kinetik
https://hg.mozilla.org/integration/autoland/rev/1025e2d81d4d
opus: Fix nonunified build patch. r=kinetik
https://hg.mozilla.org/integration/autoland/rev/0126bc63b48c
opus: Update to 1.2-rc1. r=kinetik
https://hg.mozilla.org/integration/autoland/rev/7e6229d28b18
opus: Fix unified build. r=kinetik

Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)

Comment 24

•

7 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/6d7d54dc18b7
https://hg.mozilla.org/mozilla-central/rev/1025e2d81d4d
https://hg.mozilla.org/mozilla-central/rev/0126bc63b48c
https://hg.mozilla.org/mozilla-central/rev/7e6229d28b18

Status: NEW → RESOLVED

Closed: 7 years ago

status-firefox56: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → mozilla56

Joel Maher ( :jmaher ) (UTC -8)

Comment 25

•

7 years ago

some compiler warning alerts:
== Change summary for alert #7332 (as of June 15 2017 19:52 UTC) ==

Regressions:

  2%  compiler warnings summary windows2012-32 opt      127.00 -> 129.00
  2%  compiler warnings summary windowsxp debug         133.00 -> 135.08
  2%  compiler warnings summary windowsxp opt           127.00 -> 129.00
  2%  compiler warnings summary windows2012-32 pgo      136.00 -> 138.08
  2%  compiler warnings summary windows2012-32-noopt debug 133.00 -> 135.00
  2%  compiler warnings summary windows2012-32 debug    133.00 -> 135.00

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=7332

for information only, no rules around backouts or expected responses.

Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)

Updated

•

7 years ago

Depends on: 1367208

NVD

Comment 26

•

7 years ago

http://opus-codec.org/release/stable/2017/06/20/libopus-1_2.html

Libopus 1.2 final release is out.

Ralph Giles (:rillian)

Assignee

Updated

•

7 years ago

Blocks: 1374870

You need to log in before you can comment on or make changes to this bug.