1372426 - Better naming for nsInputStreamReadyEvent

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: patch

The nsInputStreamReadyEvent shows up a lot in telemetry. There are a lot of different ways this runnable is used. I would like to use more precise names so that we can figure out which uses are the most common. That will make it easier to decide which ones to prioritize for labeling.

Eric, I know you haven't been reviewing these patches, but I'm trying to lighten the load on Nathan. I think the patch is pretty straightforward, but let me know if you need more context. https://wiki.mozilla.org/Quantum/DOM has some background.

Comment 1

[Eric Rahm [:erahm]]

Comment on attachment 8876936 [details] [diff] [review]
patch

Review of attachment 8876936 [details] [diff] [review]:
-----------------------------------------------------------------

r=me. The amount of copy and paste going on with those imgEncoders is kind of sad but obviously not your fault! Feel free to send other reviews my way.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e8a63038d787
More detailed names for nsInputStreamReadyEvent (r=erahm)

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out for build failures in nsStringStream.cpp like https://treeherder.mozilla.org/logviewer.html#?job_id=106832406&repo=mozilla-inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/df7898194f590a0bcc8cfe02766617101e3aa26b

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/45b5cadadc22
More detailed names for nsInputStreamReadyEvent (r=erahm)

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I had to back this out because it was conflicting with my backout of bug 1371699. https://hg.mozilla.org/integration/mozilla-inbound/rev/d14e2e6cae0e185a8c04b7b906c8784c6916a614

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dfee29c06556
More detailed names for nsInputStreamReadyEvent (r=erahm)

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/dfee29c06556