Closed Bug 1372426 Opened 3 years ago Closed 3 years ago

Better naming for nsInputStreamReadyEvent

Categories

(Core :: XPCOM, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: billm, Assigned: billm)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
The nsInputStreamReadyEvent shows up a lot in telemetry. There are a lot of different ways this runnable is used. I would like to use more precise names so that we can figure out which uses are the most common. That will make it easier to decide which ones to prioritize for labeling.

Eric, I know you haven't been reviewing these patches, but I'm trying to lighten the load on Nathan. I think the patch is pretty straightforward, but let me know if you need more context. https://wiki.mozilla.org/Quantum/DOM has some background.
Attachment #8876936 - Flags: review?(erahm)
Comment on attachment 8876936 [details] [diff] [review]
patch

Review of attachment 8876936 [details] [diff] [review]:
-----------------------------------------------------------------

r=me. The amount of copy and paste going on with those imgEncoders is kind of sad but obviously not your fault! Feel free to send other reviews my way.
Attachment #8876936 - Flags: review?(erahm) → review+
Pushed by wmccloskey@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e8a63038d787
More detailed names for nsInputStreamReadyEvent (r=erahm)
Pushed by wmccloskey@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/45b5cadadc22
More detailed names for nsInputStreamReadyEvent (r=erahm)
Flags: needinfo?(wmccloskey)
Pushed by wmccloskey@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dfee29c06556
More detailed names for nsInputStreamReadyEvent (r=erahm)
https://hg.mozilla.org/mozilla-central/rev/dfee29c06556
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Flags: needinfo?(wmccloskey)
Duplicate of this bug: 1352174
You need to log in before you can comment on or make changes to this bug.