Closed Bug 1372429 Opened 3 years ago Closed 3 years ago

CacheFileHandles::RemoveHandle does unnecessary hashtable lookups

Categories

(Core :: Networking: Cache, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: mats, Assigned: mats)

Details

(Keywords: perf, Whiteboard: [necko-active])

Attachments

(1 file)

It appears we had infra issues yesterday, here a better Try run:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e878dd5e5c8c3982d7d1d3c92fd22813b6159bb8
Attachment #8877166 - Flags: review?(michal.novotny) → review+
Whiteboard: [necko-active]
Pushed by mpalmgren@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8e0780d151f5
Use RemoveEntry(EntryType*) instead of RemoveEntry(KeyType) to avoid another hashtable lookup.  r=michal
https://hg.mozilla.org/mozilla-central/rev/8e0780d151f5
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.