CacheFileHandles::RemoveHandle does unnecessary hashtable lookups

RESOLVED FIXED in Firefox 56

Status

()

Core
Networking: Cache
P2
normal
RESOLVED FIXED
11 months ago
11 months ago

People

(Reporter: mats, Assigned: mats)

Tracking

({perf})

Trunk
mozilla56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

(Whiteboard: [necko-active])

Attachments

(1 attachment)

(Assignee)

Comment 1

11 months ago
It appears we had infra issues yesterday, here a better Try run:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e878dd5e5c8c3982d7d1d3c92fd22813b6159bb8
(Assignee)

Comment 2

11 months ago
Created attachment 8877166 [details] [diff] [review]
Use RemoveEntry(EntryType*) instead of RemoveEntry(KeyType) to avoid another hashtable lookup
Attachment #8877166 - Flags: review?(michal.novotny)

Updated

11 months ago
Attachment #8877166 - Flags: review?(michal.novotny) → review+

Updated

11 months ago
Whiteboard: [necko-active]

Comment 3

11 months ago
Pushed by mpalmgren@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8e0780d151f5
Use RemoveEntry(EntryType*) instead of RemoveEntry(KeyType) to avoid another hashtable lookup.  r=michal
https://hg.mozilla.org/mozilla-central/rev/8e0780d151f5
Status: NEW → RESOLVED
Last Resolved: 11 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.