Closed
Bug 1372429
Opened 7 years ago
Closed 7 years ago
CacheFileHandles::RemoveHandle does unnecessary hashtable lookups
Categories
(Core :: Networking: Cache, enhancement, P2)
Core
Networking: Cache
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: MatsPalmgren_bugz, Assigned: MatsPalmgren_bugz)
Details
(Keywords: perf, Whiteboard: [necko-active])
Attachments
(1 file)
We use RemoveEntry(KeyType) when I think we can use RemoveEntry(EntryType*) instead. WIP: https://hg.mozilla.org/try/rev/65ee31626c5980c850448e7919dc20ceda805737 Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=64d24fc8c13f3df6d30ff97cd3ec306096ccce1e
|
Assignee | |
Comment 1•7 years ago
|
||
It appears we had infra issues yesterday, here a better Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e878dd5e5c8c3982d7d1d3c92fd22813b6159bb8
|
|
Assignee | |
Comment 2•7 years ago
|
||
Attachment #8877166 -
Flags: review?(michal.novotny)
|
||
Updated•7 years ago
|
Attachment #8877166 -
Flags: review?(michal.novotny) → review+
|
||
Updated•7 years ago
|
Whiteboard: [necko-active]
Pushed by mpalmgren@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/8e0780d151f5 Use RemoveEntry(EntryType*) instead of RemoveEntry(KeyType) to avoid another hashtable lookup. r=michal
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/8e0780d151f5
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•