1372441 - Enable replay of ClientPaintedLayers off the main thread

Status: RESOLVED FIXED

(Core :: Graphics, enhancement)

Description

[Mason Chang [Inactive] [:mchang]]

+++ This bug was initially created as a clone of Bug #1371037 +++

From where we were before:

1) we record/replay on the main thread for a client painted layer. Right now, we're using DrawTargetRecording which copies everything and also paints everything while recording, so it's super slow. But it's a known working recorder for now.
2) Ship this to the paint thread!
3) Stop using DrawTargetRecording and make sure DrawTargetCapture works

Bug 1371037 was (1). This is (2)!

Comment 1

[Mason Chang [Inactive] [:mchang]]

Attachment: Replay contents on the paint thread

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 8876951 [details] [diff] [review]
Replay contents on the paint thread

Review of attachment 8876951 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/PaintThread.cpp
@@ +18,4 @@
>  StaticAutoPtr<PaintThread> PaintThread::sSingleton;
>  
> +void
> +PaintThread::Release() {}

nit:

PaintThread::Release()
{
}

@@ +33,5 @@
>  bool
>  PaintThread::Init()
>  {
>    MOZ_ASSERT(NS_IsMainThread());
>    nsresult rv = NS_NewNamedThread("PaintThread", getter_AddRefs(PaintThread::sSingleton->mThread));

Can you change this to just mThread?

@@ +42,5 @@
>  
> +  nsCOMPtr<nsIRunnable> paintInitTask =
> +    NewRunnableMethod(this, &PaintThread::InitOnPaintThread);
> +
> +  SyncRunnable::DispatchToThread(PaintThread::sSingleton->mThread, paintInitTask);

Same here, no need to go through the singleton, we have |this|.

@@ +83,5 @@
>    PaintThread::sSingleton->mThread->AsyncShutdown();
>  }
>  
> +bool
> +PaintThread::IsInPaintThread()

nit: I think we usually say "IsOn" instead of "IsIn"

::: gfx/layers/PaintThread.h
@@ +12,5 @@
>  
>  namespace mozilla {
> +namespace gfx {
> +  class DrawEventRecorderMemory;
> +  class DrawTarget;

nit: we usually don't indent for forward declarations like this

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/88eeeaeab920
Enable replay of ClientPaintedLayers off the main thread. r=dvander

Comment 4

[Mason Chang [Inactive] [:mchang]]

Try - https://treeherder.mozilla.org/#/jobs?repo=try&revision=d9a4c00a52d28ecea74ae52ca7d8eedfd087b365

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/88eeeaeab920