Closed Bug 1372476 Opened 2 years ago Closed 2 years ago

Intermittent docshell/test/browser/browser_bug349769.js | Test timed out -

Categories

(Core :: DOM: Core & HTML, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: arai)

Details

(Keywords: bulk-close-intermittents, intermittent-failure, Whiteboard: [stockwell unknown])

Attachments

(1 file)

Priority: -- → P5
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → INCOMPLETE
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---
Since 25th November there already are 36 failures.
:overholt could you please take a look?
Flags: needinfo?(overholt)
My uneducated reading of a log here makes me think checkContentProcess is failing with uri=undefined. It's odd that the failures are mostly Linux with one macOS failure.

Blake, you added the checkContentProcess method in bug 1239122. Tooru, you touched it (seems like simple refactorings, though) in bug 1321217. Can either of you think of why we'd be seeing intermittent failures here? Thank you in advance.
Flags: needinfo?(overholt)
Flags: needinfo?(mrbkap)
Flags: needinfo?(arai.unmht)
Priority: -- → P2
reproduced locally.
I'll take a look.
Assignee: nobody → arai.unmht
Status: REOPENED → ASSIGNED
BrowserTestUtils.browserLoaded should be called before calling BrowserTestUtils.loadURI, otherwise it may miss the message about load event.
https://searchfox.org/mozilla-central/rev/2e08acdf8862e68b13166970e17809a3b5d6a555/testing/mochitest/BrowserTestUtils/BrowserTestUtils.jsm#262-296
Flags: needinfo?(mrbkap)
Flags: needinfo?(arai.unmht)
Attachment #8934865 - Flags: review?(wmccloskey)
(In reply to Tooru Fujisawa [:arai] from comment #8)
> BrowserTestUtils.browserLoaded should be called before calling
> BrowserTestUtils.loadURI, otherwise it may miss the message about load event.

To be clear, it's important to call browserLoaded before spinning the event loop (in this case, the `await checkContentProcess`). The idiomatic way of loading URIs with BrowserTestUtils is: `BTU.loadURI(browser, ...); await BTU.browserLoaded(browser)`.
Attachment #8934865 - Flags: review?(wmccloskey) → review+
sorry I forgot to land
I’ll land shortly
Flags: needinfo?(arai.unmht)
Flags: needinfo?(arai.unmht)
https://hg.mozilla.org/integration/mozilla-inbound/rev/ea64f1bb6c97bfc9437a8841b1d9a2bc54938016
Bug 1372476 - Add event load listener before start loading in docshell/test/browser/browser_bug349769.js. r=billm
https://hg.mozilla.org/mozilla-central/rev/ea64f1bb6c97
Status: ASSIGNED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.