1372521 - footer in stub installer cut off in many languages (STUB_BLURB_FOOTER)

Status: VERIFIED FIXED

(Firefox :: Installer, defect, P2)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: screenshot of issue for German

Yesterday's Nightly after the version bump to 56.0a1 on Windows 8.1

The footer in the stub installer is cut off in ~half of the localized builds. See the screenshot for German as example.

In English, it's STUB_BLURB_FOOTER=The only browser built for people, not profit
https://hg.mozilla.org/mozilla-central/annotate/2a63a6c35033b5cbc6c98cabc7657c7290284691/browser/locales/en-US/installer/nsisstrings.properties#l27

Localized versions https://transvision.mozfr.org/string/?entity=browser/installer/nsisstrings.properties:STUB_BLURB_FOOTER&repo=central

The texts below the progress bar wrap and are readable and don't overlap.

Comment 1

[Molly Howell (she/her) (mostly inactive)]

Attachment: Bug 1372521 - Support multi-line stub installer footer text.

Review commit: https://reviewboard.mozilla.org/r/148638/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/148638/

Comment 2

[Robert Strong (they/them - no direct email)]

Comment on attachment 8877307 [details]
Bug 1372521 - Support multi-line stub installer footer text.

https://reviewboard.mozilla.org/r/148638/#review153238

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/70d524455cda
Support multi-line stub installer footer text. r=rstrong

Comment 4

[Molly Howell (she/her) (mostly inactive)]

Comment on attachment 8877307 [details]
Bug 1372521 - Support multi-line stub installer footer text.

Approval Request Comment
[Feature/Bug causing the regression]:
Bug 1365998

[User impact if declined]:
Cut-off text in some localizations of the stub installer; see attached screenshot.

[Is this code covered by automated tests?]:
No

[Has the fix been verified in Nightly?]:
Not yet

[Needs manual test from QE? If yes, steps to reproduce]: 
Manual verification that the footer text is entirely visible/readable in all locales would be helpful. The steps would just be to run the stub installer, look at the footer text (the text to the right of the logo), and immediately close it again.

[List of other uplifts needed for the feature/fix]:
None

[Is the change risky?]:
No

[Why is the change risky/not risky?]:
The worst that could happen is that the bug isn't fixed, nothing else would be affected.

[String changes made/needed]:
None

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/70d524455cda

Comment 6

[Julien Cristau [:jcristau]]

Comment on attachment 8877307 [details]
Bug 1372521 - Support multi-line stub installer footer text.

stub installer regression fix, beta55+

Comment 7

[Julien Cristau [:jcristau]]

Setting qe-verify so we get some coverage per comment 4.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ca50dbbf858b

Comment 9

[Camelia Badau [:cbadau], Desktop Test Engineering]

Attachment: issue.png

I've tested on Windows 7 x64 and Windows 10 x86 using latest Nightly 56.0a1 (2017-06-20) and Firefox 55 Beta 3(buildID: 20170619071723), several builds: ar, de, es-AR, es-ES, fa, fr, he, it, ru, ur and I have the following mentions: 

- the footer in the stub installer is no longer cut off
- the text overlap the Firefox icon on several localized builds, please see attachment "issue.png": 
           - on Firefox 55 Beta 3, I saw this issue on RTL builds: ar, fa, he, ur;
           - on latest Nightly 56.0a1, I saw this issue on sseveral localized builds: ar, es-AR, es-ES, fa, fr, he, nl, ru, ur 

Any thoughts about this issue?

Comment 10

[Robert Strong (they/them - no direct email)]

Filed bug 1375013 for this issue.

Comment 11

[Molly Howell (she/her) (mostly inactive)]

Will address in bug 1375013.

Comment 12

[Camelia Badau [:cbadau], Desktop Test Engineering]

Marking this issue as VERIFIED FIXED. Based on comment 10, bug 1375013 was logged for the footer text issue.