1372522 - Daily 56 x64 crashes immediately at startup on Windows. @ InterlockedDecrement and @ CDestinationCategory::ReleaseReference

Status: VERIFIED FIXED

(Thunderbird :: General, defect)

Description

[Jorg K (CEST = GMT+2)]

I've installed a Tinderbox build of TB 56 of today from
https://archive.mozilla.org/pub/thunderbird/tinderbox-builds/comm-central-win64/1497331713/

Sadly Daily crashes immediately at startup:
https://crash-stats.mozilla.com/report/index/f827fb70-9ea5-4dbe-a1c6-0ab010170613
https://crash-stats.mozilla.com/report/index/35b5307d-e795-4d2f-a42d-8f9e30170613

I have a few more crashes, but they are all the same.

My older Daily - 55.0a1 (2017-06-06) (64-bit) - works just fine.

Comment 1

[Richard Marti (:Paenglab)]

My self built Daily 32 bit generated no crash reports but hung on start until Windows asked to debug. I tried also a Tinderbox build of today and had the same. Then I started it with the shift button and choose "Disable all extensions". After the restart it hung again. Then closed it, waited and started it again, and...it worked. Also with enabling the extension it still works. :-o

Comment 2

[Jorg K (CEST = GMT+2)]

Hmm, yes, Richard's steps fix the problem. I did this:
1) Started from a shortcut with <shift> pressed. Started OK.
2) Restarted with all add-ons disabled (from Help menu). Worked OK.
3) Restarted with add-ons enabled again. Worked OK.
4) Started on another profile which hadn't gone through steps 1)-3) and had failed previouisly. Worked OK.
Weird. BTW, what does the "shift start" do? Supposedly that's "Safe Mode" (http://kb.mozillazine.org/Safe_mode), but the add-on were enabled.

Comment 3

[Richard Marti (:Paenglab)]

It's like the "Restart with Add-ons disabled* menuitem but only directly from start. Do you have a untouched profile where you can check the difference before the first TB 56 start and after the procedure above?

Comment 4

[Jorg K (CEST = GMT+2)]

I have an untouched profile where my locally compiled x86 build doesn't crash, but the TB 56 x64 Tinderbox build does.

Which difference should I check exactly?

Comment 5

[Jorg K (CEST = GMT+2)]

The funny thing is, holding down <shift> doesn't disable add-ons. Lightning is enabled and the calendar shows.

Comment 6

[Richard Marti (:Paenglab)]

(In reply to Jorg K (GMT+2) from comment #4)
> Which difference should I check exactly?

I don't know what. It was only a guess to find what could trigger this behavior.

(In reply to Jorg K (GMT+2) from comment #5)
> The funny thing is, holding down <shift> doesn't disable add-ons. Lightning
> is enabled and the calendar shows.

Here the dialog which asks what I want do (disable add-ons, reset toolbars, start in safe mode etc.) opens.

Comment 7

[Wayne Mery (:wsmwk)]

FWIW a couple SM crashes like bp-90f02fac-3e38-457f-b60c-3e20d0170613

Comment 8

[Jorg K (CEST = GMT+2)]

Funny, the crash had gone away two days ago and this morning it was back. Now it's gone again.

Comment 9

[Richard Marti (:Paenglab)]

I can't use Daily, neither 32bit nor 64bit, anymore. Some times it starts but mostly it hangs. Also a new empty profile shows the error. A self built 32bit TB works on this profiles. The last stable Daily is the 55 from 170612.

Comment 10

[Frank-Rainer Grahl (:frg)]

Maybe this one:

https://hg.mozilla.org/mozilla-central/rev/1ce78807187a

Comment 11

[Jorg K (CEST = GMT+2)]

Fixed by bug 1373565. I tried a Tinderbox build and I don't see any crashes any more.

Comment 12

[Wayne Mery (:wsmwk)]

Do we know why no win10 users are showing in crash-stats?
https://crash-stats.mozilla.com/signature/?signature=CDestinationCategory%3A%3AReleaseReference&date=%3E%3D2017-06-11T18%3A12%3A00.000Z&date=%3C2017-06-18T18%3A12%3A00.000Z&_columns=date&_columns=product&_columns=version&_columns=build_id&_columns=platform&_columns=reason&_columns=address&_columns=install_time&_sort=-date&page=1#summary

And this doesn't affect 32-bit builds?  (In which case no one using mozilla beta windows downloads will be affected)

Might InterlockedDecrement be related?  It is a startu crash that happens in both nightly and 55 beta.
https://crash-stats.mozilla.com/signature/?product=Thunderbird&signature=InterlockedDecrement&date=%3E%3D2017-06-04T18%3A35%3A02.000Z&date=%3C2017-06-18T18%3A35%3A02.000Z#summary

Comment 13

[Richard Marti (:Paenglab)]

On Win10 there comes only the system dialog the application does not respond and we can only close it or wait a bit until it asks to debug Daily.

Comment 14

[Frank-Rainer Grahl (:frg)]

>> Do we know why no win10 users are showing in crash-stats?

The Windows 10 start menu is braindead. I think it does not even have jumplists. Same for 8 I think but not sure here.

>> And this doesn't affect 32-bit builds?  (In which case no one using mozilla beta windows downloads will be affected)

Both should be affected. 

>> Might InterlockedDecrement be related? 

Yes. This is the same bug. I incorrectly set the flags in bug 1373565. The first patch still needs to be checked into comm-beta. Jorg will you do this or should I?

Comment 15

[Richard Marti (:Paenglab)]

Attachment: Win10-Jumplist.png

(In reply to Frank-Rainer Grahl (:frg) from comment #14)
> >> Do we know why no win10 users are showing in crash-stats?
> 
> The Windows 10 start menu is braindead. I think it does not even have
> jumplists. Same for 8 I think but not sure here.

Not quite right as you can see in the screenshot. Also the icon in the taskbar shows the jumplist.

Comment 16

[Frank-Rainer Grahl (:frg)]

Ahh ok. I have Classic Shell installed in my VM and wasn't sure.

Comment 17

[Jorg K (CEST = GMT+2)]

(In reply to Wayne Mery (:wsmwk, NI for questions) from comment #12)
> And this doesn't affect 32-bit builds?  (In which case no one using mozilla
> beta windows downloads will be affected)
No idea, but CDestinationList clearly is the "jump list" and we know that this broke due to changes in M-C. So better be safe than sorry.

(In reply to Frank-Rainer Grahl (:frg) from comment #14)
> Jorg will you do this or should I?
I'll do the uplifts, I have three so far: https://mzl.la/2sMTzqr

Comment 18

[Frank-Rainer Grahl (:frg)]

Thanks. SeaMonkey beta is still closed. Don't have a clue why and asked ewong. Just push with closed tree for suite.

Comment 19

[Wayne Mery (:wsmwk)]

Given this cause InterlockedDecrement crashes I agree we need to abandon 55.0b1

Comment 20

[Wayne Mery (:wsmwk)]

v.fixed on nightly for CDestinationCategory::ReleaseReference. Last build to crash is 20170616030206

Comment 21

[Wayne Mery (:wsmwk)]

Landed on beta per bug 1373565 comment 21
Beta (TB 55):
https://hg.mozilla.org/releases/comm-beta/rev/9b1fdf35d3e1cd80afb8866305125469e859faf3