Closed
Bug 1372523
Opened 7 years ago
Closed 7 years ago
Remove isSecurityUpdate, showNeverForVersion, and showPrompt from nsIUpdate
Categories
(Toolkit :: Application Update, enhancement)
Toolkit
Application Update
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)
Details
Attachments
(2 files, 4 obsolete files)
17.34 KB,
patch
|
molly
:
review+
|
Details | Diff | Splinter Review |
111.58 KB,
patch
|
molly
:
review+
|
Details | Diff | Splinter Review |
The showNeverForVersion and showPrompt attributes are not used in the new interface and isSecurityUpdate has never been used. I will also be cleaning up the tests so it is easier to make future changes when change the xml for nsIUpdate and nsIUpdatePatch.
Assignee | ||
Comment 1•7 years ago
|
||
Assignee | ||
Comment 2•7 years ago
|
||
Attachment #8877078 -
Attachment is obsolete: true
Assignee | ||
Comment 3•7 years ago
|
||
Assignee | ||
Comment 4•7 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=fe0e0d10eaf1b9f5456ef2037569040422a25d6e
Attachment #8877478 -
Attachment is obsolete: true
Assignee | ||
Updated•7 years ago
|
Attachment #8877477 -
Flags: review?(mhowell)
Assignee | ||
Comment 5•7 years ago
|
||
Comment on attachment 8877495 [details] [diff] [review] patch rev1 - test code Sorry about the size of the patch. I got tired of modifying all of the call sites when creating the xml for the updates and converted the functions to use objects so it shouldn't require major changes in the future.
Attachment #8877495 -
Flags: review?(mhowell)
Assignee | ||
Comment 6•7 years ago
|
||
I also found bug 1372834 while working on this and it turns out that bug exists without these changes,
Assignee | ||
Comment 7•7 years ago
|
||
Henrik, just a heads up though I don't think these changes will affect your tests.
Flags: needinfo?(hskupin)
Comment 8•7 years ago
|
||
(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #7) > Henrik, just a heads up though I don't think these changes will affect your > tests. Thank you for the heads up. I can second that we do not make use of any of those properties or methods. So nothing would have to be changed for update tests.
Flags: needinfo?(hskupin)
Assignee | ||
Comment 9•7 years ago
|
||
Forgot to qrefresh :( Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=6650393c01751b1aa039f655cfb3e96fa090bf86
Attachment #8877495 -
Attachment is obsolete: true
Attachment #8877495 -
Flags: review?(mhowell)
Attachment #8877564 -
Flags: review?(mhowell)
Assignee | ||
Comment 10•7 years ago
|
||
Sorry, I missed updating a couple of tests.
Attachment #8877564 -
Attachment is obsolete: true
Attachment #8877564 -
Flags: review?(mhowell)
Attachment #8877626 -
Flags: review?(mhowell)
Updated•7 years ago
|
Attachment #8877477 -
Flags: review?(mhowell) → review+
Comment 11•7 years ago
|
||
Comment on attachment 8877626 [details] [diff] [review] patch rev3 - test code Review of attachment 8877626 [details] [diff] [review]: ----------------------------------------------------------------- (In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #5) > Sorry about the size of the patch. I got tired of modifying all of the call > sites when creating the xml for the updates and converted the functions to > use objects so it shouldn't require major changes in the future. I've had my own run-ins with that interface before, and having this change is absolutely worth it.
Attachment #8877626 -
Flags: review?(mhowell) → review+
Comment 12•7 years ago
|
||
Pushed by rstrong@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/0382d15e3734 Remove the isSecurityUpdate, showNeverForVersion, and showPrompt attributes from nsIUpdate and the use of these attributes. r=mhowell https://hg.mozilla.org/integration/mozilla-inbound/rev/53af1e0611e1 Update tests for the removal of the isSecurityUpdate, showNeverForVersion, and showPrompt attributes from nsIUpdate. r=mhowell
Comment 13•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/0382d15e3734 https://hg.mozilla.org/mozilla-central/rev/53af1e0611e1
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•