Closed Bug 1372523 Opened 7 years ago Closed 7 years ago

Remove isSecurityUpdate, showNeverForVersion, and showPrompt from nsIUpdate

Categories

(Toolkit :: Application Update, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)

Details

Attachments

(2 files, 4 obsolete files)

The showNeverForVersion and showPrompt attributes are not used in the new interface and isSecurityUpdate has never been used.

I will also be cleaning up the tests so it is easier to make future changes when change the xml for nsIUpdate and nsIUpdatePatch.
Attached patch patch in progress (obsolete) — Splinter Review
Attachment #8877078 - Attachment is obsolete: true
Attachment #8877477 - Flags: review?(mhowell)
Comment on attachment 8877495 [details] [diff] [review]
patch rev1 - test code

Sorry about the size of the patch. I got tired of modifying all of the call sites when creating the xml for the updates and converted the functions to use objects so it shouldn't require major changes in the future.
Attachment #8877495 - Flags: review?(mhowell)
I also found bug 1372834 while working on this and it turns out that bug exists without these changes,
Henrik, just a heads up though I don't think these changes will affect your tests.
Flags: needinfo?(hskupin)
(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #7)
> Henrik, just a heads up though I don't think these changes will affect your
> tests.

Thank you for the heads up. I can second that we do not make use of any of those properties or methods. So nothing would have to be changed for update tests.
Flags: needinfo?(hskupin)
Attached patch patch rev2 - test code (obsolete) — Splinter Review
Forgot to qrefresh :(

Pushed to try
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6650393c01751b1aa039f655cfb3e96fa090bf86
Attachment #8877495 - Attachment is obsolete: true
Attachment #8877495 - Flags: review?(mhowell)
Attachment #8877564 - Flags: review?(mhowell)
Sorry, I missed updating a couple of tests.
Attachment #8877564 - Attachment is obsolete: true
Attachment #8877564 - Flags: review?(mhowell)
Attachment #8877626 - Flags: review?(mhowell)
Attachment #8877477 - Flags: review?(mhowell) → review+
Comment on attachment 8877626 [details] [diff] [review]
patch rev3 - test code

Review of attachment 8877626 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #5)
> Sorry about the size of the patch. I got tired of modifying all of the call
> sites when creating the xml for the updates and converted the functions to
> use objects so it shouldn't require major changes in the future.

I've had my own run-ins with that interface before, and having this change is absolutely worth it.
Attachment #8877626 - Flags: review?(mhowell) → review+
Pushed by rstrong@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0382d15e3734
Remove the isSecurityUpdate, showNeverForVersion, and showPrompt attributes from nsIUpdate and the use of these attributes. r=mhowell
https://hg.mozilla.org/integration/mozilla-inbound/rev/53af1e0611e1
Update tests for the removal of the isSecurityUpdate, showNeverForVersion, and showPrompt attributes from nsIUpdate. r=mhowell
https://hg.mozilla.org/mozilla-central/rev/0382d15e3734
https://hg.mozilla.org/mozilla-central/rev/53af1e0611e1
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: