1372560 - [TSF] Investigate if it's possible to cache compartment of GUID_COMPARTMENT_KEYBOARD_OPENCLOSE

Status: RESOLVED FIXED

(Core :: Widget: Win32, enhancement)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

The compartment of GUID_COMPARTMENT_KEYBOARD_OPENCLOSE may be retrieved a lot (perhaps, every focus change and more). It needs a QI and a virtual call. Additionally, GetCompartment() sometimes appears in some crash reports which are caused by bugs of TSF or TIP. So, if it's possible to cache the compartment, we can reduce running cost and/or number of crashes.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3611d33e8fea68ef4057ba501e75657aa16c9e8b

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1f86501359e220f7bc792f58f821b7a601dde74f

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1372560 TSFTextStore should cache compartment for keyboard open/close

TSFTextStore::GetIMEOpenState() may be called a lot.  Therefore, TSFTextStore should cache the compartment until shutting down.

Review commit: https://reviewboard.mozilla.org/r/148840/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/148840/

Comment 4

[Makoto Kato [:m_kato]]

Comment on attachment 8877428 [details]
Bug 1372560 TSFTextStore should cache compartment for keyboard open/close

https://reviewboard.mozilla.org/r/148840/#review153432

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c4121a9a2281
TSFTextStore should cache compartment for keyboard open/close r=m_kato

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/c4121a9a2281