Closed Bug 1372560 Opened 4 years ago Closed 4 years ago

[TSF] Investigate if it's possible to cache compartment of GUID_COMPARTMENT_KEYBOARD_OPENCLOSE

Categories

(Core :: Widget: Win32, enhancement)

All
Windows
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

Details

(Keywords: inputmethod, Whiteboard: tpi:+)

Attachments

(1 file)

The compartment of GUID_COMPARTMENT_KEYBOARD_OPENCLOSE may be retrieved a lot (perhaps, every focus change and more). It needs a QI and a virtual call. Additionally, GetCompartment() sometimes appears in some crash reports which are caused by bugs of TSF or TIP. So, if it's possible to cache the compartment, we can reduce running cost and/or number of crashes.
Comment on attachment 8877428 [details]
Bug 1372560 TSFTextStore should cache compartment for keyboard open/close

https://reviewboard.mozilla.org/r/148840/#review153432
Attachment #8877428 - Flags: review?(m_kato) → review+
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/c4121a9a2281
TSFTextStore should cache compartment for keyboard open/close r=m_kato
Whiteboard: tpi:+
https://hg.mozilla.org/mozilla-central/rev/c4121a9a2281
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.