|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
I'm working to integrate MozillaOnline changes into our mainline Fennec so that they can merge easier (and so that we can see what they are changing). This is the first patch. MozillaOnline adds a home button in the URL bar (as a page action). While we want a home button in Fennec, this is not a location where we would do so. Their original patch is here: https://github.com/MozillaOnline/gecko-dev/commit/a9ab10aa8438c2b265527583c0529357bc2cf709 I have completely rewritten it and moved the location of the homepage code, but the behavior is the same.
Created attachment 8877225 [details] [diff] [review] Add MOZ_ANDROID_MOZILLA_ONLINE to AppConstants.jsm Because I'm using MOZ_ANDROID_MOZILLA_ONLINE in a JS file, I need it in AppConstants.jsm.
Attachment #8877225 - Flags: review?(nalexander)
Comment on attachment 8877225 [details] [diff] [review] Add MOZ_ANDROID_MOZILLA_ONLINE to AppConstants.jsm Review of attachment 8877225 [details] [diff] [review]: ----------------------------------------------------------------- lgtm.
Attachment #8877225 - Flags: review?(nalexander) → review+
Cross-link to Bug 1093113?
Attachment #8877148 - Flags: review?(snorp) → review?(max)
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/87895cdc8d92 Enable MOZ_ANDROID_MOZILLA_ONLINE for JS files. r=nalexander
Status: NEW → RESOLVED
Last Resolved: 8 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Comment on attachment 8877148 [details] Bug 1372572 - Port MozillaOnline code for a homepage page action. https://reviewboard.mozilla.org/r/148480/#review154482 LGTM
Attachment #8877148 - Flags: review?(max) → review+
Forgot to mark as leaveopen for the rest of the patch.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
I'm reasking for review because I discovered a few issues. 1. I needed to add a string for the text of the button because it gets read by Talkback. 2. The button was getting duplicated every time you reopened the browser. 3. I forgot the image for the button. I named it home.png
You need to log in before you can comment on or make changes to this bug.