1372622 - Remove AudioClassifier

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, enhancement)

Description

[Ralph Giles (:rillian)]

The AudioClassifier class seems to be dead code, and was removed upstream per https://bugs.chromium.org/p/webrtc/issues/detail?id=5676

I'd like to remove it in Gecko as well.

Comment 1

[Ralph Giles (:rillian)]

Attachment: Bug 1372622 - webrtc: Remove AudioClassifier.

This is no longer called from anywhere, and because it calls
into private libopus APIs it needs regular changes. Remove
to reduce the maintenance effort.

It was removed upstream per
https://bugs.chromium.org/p/webrtc/issues/detail?id=5676

Review commit: https://reviewboard.mozilla.org/r/148582/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/148582/

Comment 2

[Ralph Giles (:rillian)]

Comment on attachment 8877203 [details]
Bug 1372622 - webrtc: Remove AudioClassifier.

https://reviewboard.mozilla.org/r/148582/#review152980

NB this just removes the code. I didn't attempt to patch the update script. It looks like we haven't pulled from upstream in a while, and if we do, it should already contain this change, so hopefully that's ok.

Comment 3

[Nils Ohlmeier [:drno]]

Comment on attachment 8877203 [details]
Bug 1372622 - webrtc: Remove AudioClassifier.

https://reviewboard.mozilla.org/r/148582/#review152988

It's always good to delete code which don't need any more :-)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e9227c17f3bc
webrtc: Remove AudioClassifier. r=drno

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I had to back this out because it's causing conflicts for me trying to merge mozilla-central over to autoland after bug 1341285 landed. Feel free to rebase and reland.

https://hg.mozilla.org/integration/autoland/rev/64d17537e11f

Comment 6

[Ralph Giles (:rillian)]

Ok, thanks for the update. Jesup's patch was more important.

Comment 7

[Ralph Giles (:rillian)]

I'm going to go ahead and close this. Bug 1341285 put back the neteq_tests.gypi entry, but apparently it's dead code since the implementation file is still removed. Otherwise the pull from upstream did the same thing this change did.