Closed
Bug 1372622
Opened 7 years ago
Closed 7 years ago
Remove AudioClassifier
Categories
(Core :: WebRTC: Audio/Video, enhancement)
Core
WebRTC: Audio/Video
Tracking
()
RESOLVED
FIXED
People
(Reporter: rillian, Assigned: rillian)
References
Details
Attachments
(1 file)
The AudioClassifier class seems to be dead code, and was removed upstream per https://bugs.chromium.org/p/webrtc/issues/detail?id=5676 I'd like to remove it in Gecko as well.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → giles
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8877203 [details] Bug 1372622 - webrtc: Remove AudioClassifier. https://reviewboard.mozilla.org/r/148582/#review152980 NB this just removes the code. I didn't attempt to patch the update script. It looks like we haven't pulled from upstream in a while, and if we do, it should already contain this change, so hopefully that's ok.
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8877203 [details] Bug 1372622 - webrtc: Remove AudioClassifier. https://reviewboard.mozilla.org/r/148582/#review152988 It's always good to delete code which don't need any more :-)
Attachment #8877203 -
Flags: review?(drno) → review+
Pushed by rgiles@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e9227c17f3bc webrtc: Remove AudioClassifier. r=drno
I had to back this out because it's causing conflicts for me trying to merge mozilla-central over to autoland after bug 1341285 landed. Feel free to rebase and reland. https://hg.mozilla.org/integration/autoland/rev/64d17537e11f
Flags: needinfo?(rjesup)
Flags: needinfo?(giles)
Assignee | ||
Comment 6•7 years ago
|
||
Ok, thanks for the update. Jesup's patch was more important.
Flags: needinfo?(giles)
Assignee | ||
Comment 7•7 years ago
|
||
I'm going to go ahead and close this. Bug 1341285 put back the neteq_tests.gypi entry, but apparently it's dead code since the implementation file is still removed. Otherwise the pull from upstream did the same thing this change did.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Flags: needinfo?(rjesup)
You need to log in
before you can comment on or make changes to this bug.
Description
•