If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

[AWSY] Add an option to output parse_about_memory.py results in mebibytes

RESOLVED FIXED in Firefox 56

Status

Testing
AWSY
RESOLVED FIXED
3 months ago
7 days ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

Version 3
mozilla56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

3 months ago
about:memory uses mebibytes, not bytes, which makes comparing the contents of about:memory to parse_about_memory.py very tedious.
(Assignee)

Comment 1

3 months ago
Created attachment 8877305 [details] [diff] [review]
Add an option to output parse_about_memory.py results in mebibytes.

This makes it easier to compare results to about:memory.
Attachment #8877305 - Flags: review?(erahm)
(In reply to Andrew McCreight [:mccr8] from comment #1)
> Created attachment 8877305 [details] [diff] [review]
> Add an option to output parse_about_memory.py results in mebibytes.
> 
> This makes it easier to compare results to about:memory.

FWIW I just check 'verbose' when loading the report.
Comment on attachment 8877305 [details] [diff] [review]
Add an option to output parse_about_memory.py results in mebibytes.

Review of attachment 8877305 [details] [diff] [review]:
-----------------------------------------------------------------

Not super stoked on '--mebi' but meh. |ls| has '-h' for 'human readable'

::: testing/awsy/awsy/parse_about_memory.py
@@ +156,4 @@
>      for (k, v) in sorted_totals:
>          if v:
> +            if args.mebi:
> +                print "{0:.2f}".format(v / bytes_per_mebibyte),

Maybe include MiB (or just MB like about:memory) at the end of the value?
Attachment #8877305 - Flags: review?(erahm) → review+
(Assignee)

Comment 4

3 months ago
(In reply to Eric Rahm [:erahm] (please no mozreview requests) from comment #3)
> Maybe include MiB (or just MB like about:memory) at the end of the value?

That's a good idea. I'll also add "bytes" as the units in the default case.
(Assignee)

Comment 5

3 months ago
Created attachment 8877691 [details] [diff] [review]
Add an option to output parse_about_memory.py results in mebibytes.

This makes it easier to compare results to about:memory.
Attachment #8877691 - Flags: review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/70e68a66dd9b8b46a47324d5bffe6a27cf01f337
Bug 1372714 - Add an option to output parse_about_memory.py results in mebibytes. r=erahm
https://hg.mozilla.org/mozilla-central/rev/70e68a66dd9b
Status: NEW → RESOLVED
Last Resolved: 3 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56

Updated

7 days ago
Component: General → AWSY
You need to log in before you can comment on or make changes to this bug.