Clean up run-on-projects

RESOLVED FIXED in Firefox 56

Status

RESOLVED FIXED
a year ago
8 months ago

People

(Reporter: gps, Assigned: gps)

Tracking

unspecified
mozilla56

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(5 attachments)

(Assignee)

Description

a year ago
The run-on-projects taskgraph attribute needs some cleanup.

"stylo" is no longer actively used and can be deleted.

Also, we have boilerplate repetition for the "trunk" repos {central, autoland, inbound}. Let's just add an alias and be done with it.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 6

a year ago
mozreview-review
Comment on attachment 8877319 [details]
Bug 1372721 - Remove "stylo" from run-on-projects lists;

https://reviewboard.mozilla.org/r/148660/#review153100
Attachment #8877319 - Flags: review?(dustin) → review+

Comment 7

a year ago
mozreview-review
Comment on attachment 8877320 [details]
Bug 1372721 - Use set literals;

https://reviewboard.mozilla.org/r/148662/#review153102

Did you see the talk on "Prehistoric Python" from PyCon US 2017?  It didn't mention set literals, but it should have :)
Attachment #8877320 - Flags: review?(dustin) → review+

Comment 8

a year ago
mozreview-review
Comment on attachment 8877321 [details]
Bug 1372721 - Remove run-on-projects from source-test tasks;

https://reviewboard.mozilla.org/r/148664/#review153104
Attachment #8877321 - Flags: review?(dustin) → review+

Comment 9

a year ago
mozreview-review
Comment on attachment 8877322 [details]
Bug 1372721 - Collapse some run-on-projects values;

https://reviewboard.mozilla.org/r/148666/#review153106

::: taskcluster/ci/test/tests.yml:12
(Diff revision 1)
>  
>  awsy:
>      description: "Are we slim yet"
>      suite: awsy
>      treeherder-symbol: tc-SY(sy)
> -    run-on-projects: ['mozilla-beta', 'mozilla-aurora', 'mozilla-central', 'mozilla-inbound', 'autoland', 'try']
> +    run-on-projects: ['release', 'trunk', 'try']

`trunk` isn't defined at this point, but I see that it is defined in the next cset.
Attachment #8877322 - Flags: review?(dustin) → review+

Comment 10

a year ago
mozreview-review
Comment on attachment 8877323 [details]
Bug 1372721 - Add a "trunk" alias for run-on-projects;

https://reviewboard.mozilla.org/r/148668/#review153108

::: taskcluster/taskgraph/util/attributes.py:79
(Diff revision 1)
>          if project in INTEGRATION_PROJECTS:
>              return True
>      if 'release' in run_on_projects:
>          if project in RELEASE_PROJECTS:
>              return True
> +    if 'trunk' in run_on_projects:

Please also document in `taskcluster/docs/attributes.rst`.
Attachment #8877323 - Flags: review?(dustin) → review+
(Assignee)

Comment 11

a year ago
mozreview-review-reply
Comment on attachment 8877322 [details]
Bug 1372721 - Collapse some run-on-projects values;

https://reviewboard.mozilla.org/r/148666/#review153106

> `trunk` isn't defined at this point, but I see that it is defined in the next cset.

Will move to the last commit. I missed this as part of an interactive commit. Derp.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 15

a year ago
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dcfbcac9801a
Remove "stylo" from run-on-projects lists; r=dustin
https://hg.mozilla.org/integration/autoland/rev/38faa7d2c936
Use set literals; r=dustin
https://hg.mozilla.org/integration/autoland/rev/c01b9173e0b5
Remove run-on-projects from source-test tasks; r=dustin
https://hg.mozilla.org/integration/autoland/rev/943eb1e43eb0
Collapse some run-on-projects values; r=dustin
https://hg.mozilla.org/integration/autoland/rev/c3a290d58b7d
Add a "trunk" alias for run-on-projects; r=dustin

Comment 16

a year ago
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5e0ed7f3ec6d
Fix flake8 failure introduced in c3a290d58b7d; r=me

Updated

8 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.