1372721 - Clean up run-on-projects

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Gregory Szorc [:gps]]

The run-on-projects taskgraph attribute needs some cleanup.

"stylo" is no longer actively used and can be deleted.

Also, we have boilerplate repetition for the "trunk" repos {central, autoland, inbound}. Let's just add an alias and be done with it.

Comment 1

[Gregory Szorc [:gps]]

Attachment: Bug 1372721 - Remove "stylo" from run-on-projects lists;

This refers to the incubator/stylo repo, which has been dead for a
few months ever since Stylo was merged into mozilla-central. Let's
remove references to it.

Review commit: https://reviewboard.mozilla.org/r/148660/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/148660/

Comment 2

[Gregory Szorc [:gps]]

Attachment: Bug 1372721 - Use set literals;

We require Python 2.7. We can have nice things.

Review commit: https://reviewboard.mozilla.org/r/148662/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/148662/

Comment 3

[Gregory Szorc [:gps]]

Attachment: Bug 1372721 - Remove run-on-projects from source-test tasks;

The default value for run-on-projects is "all." Many of the tasks
changed in this commit were defining "run-on-projects" to
integration+release, which is essentially all (notably missing "try"). I
can't think of a good reason to not schedule these lint tasks on all
repos by default. So just do that.

Review commit: https://reviewboard.mozilla.org/r/148664/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/148664/

Comment 4

[Gregory Szorc [:gps]]

Attachment: Bug 1372721 - Collapse some run-on-projects values;

I like when my code search yields relevant data with 1 line of context.

Review commit: https://reviewboard.mozilla.org/r/148666/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/148666/

Comment 5

[Gregory Szorc [:gps]]

Attachment: Bug 1372721 - Add a "trunk" alias for run-on-projects;

{central, autoland, inbound} are logically treated as a single unit for
many tasks and policies. Let's formalize that collection via a "trunk"
alias.

Review commit: https://reviewboard.mozilla.org/r/148668/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/148668/

Comment 6

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8877319 [details]
Bug 1372721 - Remove "stylo" from run-on-projects lists;

https://reviewboard.mozilla.org/r/148660/#review153100

Comment 7

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8877320 [details]
Bug 1372721 - Use set literals;

https://reviewboard.mozilla.org/r/148662/#review153102

Did you see the talk on "Prehistoric Python" from PyCon US 2017?  It didn't mention set literals, but it should have :)

Comment 8

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8877321 [details]
Bug 1372721 - Remove run-on-projects from source-test tasks;

https://reviewboard.mozilla.org/r/148664/#review153104

Comment 9

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8877322 [details]
Bug 1372721 - Collapse some run-on-projects values;

https://reviewboard.mozilla.org/r/148666/#review153106

::: taskcluster/ci/test/tests.yml:12
(Diff revision 1)
>  
>  awsy:
>      description: "Are we slim yet"
>      suite: awsy
>      treeherder-symbol: tc-SY(sy)
> -    run-on-projects: ['mozilla-beta', 'mozilla-aurora', 'mozilla-central', 'mozilla-inbound', 'autoland', 'try']
> +    run-on-projects: ['release', 'trunk', 'try']

`trunk` isn't defined at this point, but I see that it is defined in the next cset.

Comment 10

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8877323 [details]
Bug 1372721 - Add a "trunk" alias for run-on-projects;

https://reviewboard.mozilla.org/r/148668/#review153108

::: taskcluster/taskgraph/util/attributes.py:79
(Diff revision 1)
>          if project in INTEGRATION_PROJECTS:
>              return True
>      if 'release' in run_on_projects:
>          if project in RELEASE_PROJECTS:
>              return True
> +    if 'trunk' in run_on_projects:

Please also document in `taskcluster/docs/attributes.rst`.

Comment 11

[Gregory Szorc [:gps]]

Comment on attachment 8877322 [details]
Bug 1372721 - Collapse some run-on-projects values;

https://reviewboard.mozilla.org/r/148666/#review153106

> `trunk` isn't defined at this point, but I see that it is defined in the next cset.

Will move to the last commit. I missed this as part of an interactive commit. Derp.

Comment 12

[Gregory Szorc [:gps]]

Comment on attachment 8877322 [details]
Bug 1372721 - Collapse some run-on-projects values;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/148666/diff/1-2/

Comment 13

[Gregory Szorc [:gps]]

Comment on attachment 8877323 [details]
Bug 1372721 - Add a "trunk" alias for run-on-projects;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/148668/diff/1-2/

Comment 14

[Gregory Szorc [:gps]]

Comment on attachment 8877323 [details]
Bug 1372721 - Add a "trunk" alias for run-on-projects;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/148668/diff/2-3/

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dcfbcac9801a
Remove "stylo" from run-on-projects lists; r=dustin
https://hg.mozilla.org/integration/autoland/rev/38faa7d2c936
Use set literals; r=dustin
https://hg.mozilla.org/integration/autoland/rev/c01b9173e0b5
Remove run-on-projects from source-test tasks; r=dustin
https://hg.mozilla.org/integration/autoland/rev/943eb1e43eb0
Collapse some run-on-projects values; r=dustin
https://hg.mozilla.org/integration/autoland/rev/c3a290d58b7d
Add a "trunk" alias for run-on-projects; r=dustin

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5e0ed7f3ec6d
Fix flake8 failure introduced in c3a290d58b7d; r=me

Comment 17

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/dcfbcac9801a
https://hg.mozilla.org/mozilla-central/rev/38faa7d2c936
https://hg.mozilla.org/mozilla-central/rev/c01b9173e0b5
https://hg.mozilla.org/mozilla-central/rev/943eb1e43eb0
https://hg.mozilla.org/mozilla-central/rev/c3a290d58b7d
https://hg.mozilla.org/mozilla-central/rev/5e0ed7f3ec6d