Use DrawTargetCapture instead of DrawTargetRecording

RESOLVED FIXED in Firefox 56

Status

()

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: mchang, Assigned: mchang)

Tracking

(Blocks 1 bug)

unspecified
mozilla56
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox56 fixed)

Details

(Whiteboard: gfx-noted)

Attachments

(1 attachment)

+++ This bug was initially created as a clone of Bug #1372441 +++

From where we were before:

1) we record/replay on the main thread for a client painted layer. Right now, we're using DrawTargetRecording which copies everything and also paints everything while recording, so it's super slow. But it's a known working recorder for now.
2) Ship this to the paint thread!
3) Stop using DrawTargetRecording and make sure DrawTargetCapture works

Bug 1371037 was (1). Bug 1372441 was (2). This is (3)!

The nice thing about DrawTargetCapture is that it doesn't copy all the resources off main thread, it just does thread unsafe replay onto a target DT. We'll have to make DrawTargetCapture thread safe in a follow up.
Attachment #8877330 - Flags: review?(dvander)
Attachment #8877330 - Flags: review?(dvander) → review+

Comment 2

2 years ago
Pushed by mchang@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c8b7fc3e5ffd
Use DrawTargetCapture instead of DrawTargetRecording for omtp. r=dvander

Comment 3

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/c8b7fc3e5ffd
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Assignee

Updated

2 years ago
Blocks: 1379322
You need to log in before you can comment on or make changes to this bug.